From: Ben Widawsky <ben@bwidawsk.net>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap
Date: Tue, 24 Jan 2012 20:02:55 -0800 [thread overview]
Message-ID: <4F1F7EEF.2010603@bwidawsk.net> (raw)
In-Reply-To: <86ipk0ln87.fsf@sumi.keithp.com>
On 01/24/12 15:00, Keith Packard wrote:
> On Tue, 24 Jan 2012 14:42:03 -0800, Ben Widawsky<ben@bwidawsk.net> wrote:
>
>> This patch fixes gem_unref_active_buffers from i-g-t in the non-VTd
>> case (ie. do_idle_maps forced to true).
>
> Nice, one-line fix.
>
> (if you agree with my<bikeshed> in the previous patch, this will have
> to be changed to match)
>
> Reviewed-by: Keith Packard<keithp@keithp.com>
>
I agree with the bikeshed, however I am not sure what you expect changed
here. do_idle_maps is still forced to true to test the fix. So I'm going
to assume you just read the comment too quickly and resubmit with the
updated patches.
next prev parent reply other threads:[~2012-01-25 4:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 22:42 [PATCH 1/2] drm/i915: argument for deferring retirement Ben Widawsky
2012-01-24 22:42 ` [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap Ben Widawsky
2012-01-24 23:00 ` Keith Packard
2012-01-25 4:02 ` Ben Widawsky [this message]
2012-01-25 15:50 ` Keith Packard
2012-01-24 23:00 ` [PATCH 1/2] drm/i915: argument for deferring retirement Keith Packard
2012-01-24 23:05 ` Eugeni Dodonov
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 4:36 [PATCH 0/2] infinite revusion patches v9999 Ben Widawsky
2012-01-25 4:36 ` [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1F7EEF.2010603@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.