All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>,
	xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH V2] xfstests: mount other filesystems with selinux context as well
Date: Wed, 25 Jan 2012 15:11:39 -0600	[thread overview]
Message-ID: <4F20700B.8060307@sandeen.net> (raw)
In-Reply-To: <20120124174500.GB9853@infradead.org>

For some reason, non-xfs filesystems aren't getting mounted with
the selinux context; perhaps because none of the xattr tests used
to work on anything but xfs?

Anyway, 062 fails for extN unless we mount with the fs-wide
context.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

ps: eparis says this should work for NFS as well, let's go for
it and if infrequently tested filesystems have trouble we can
exclude them as necessary.

diff --git a/common.rc b/common.rc
index 6231457..602513a 100644
--- a/common.rc
+++ b/common.rc
@@ -72,11 +72,11 @@ _mount_opts()
     # nfs_t is a "liberal" context so we can use it.
     if [ -x /usr/sbin/selinuxenabled ] && /usr/sbin/selinuxenabled; then
 	SELINUX_MOUNT_OPTIONS="-o context=system_u:object_r:nfs_t:s0"
+	export SELINUX_MOUNT_OPTIONS
     fi
 
     case $FSTYP in
     xfs)
-	export SELINUX_MOUNT_OPTIONS
 	export MOUNT_OPTIONS=$XFS_MOUNT_OPTIONS
 	;;
     udf)



WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>,
	xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH V2] xfstests: mount other filesystems with selinux context as well
Date: Wed, 25 Jan 2012 15:11:39 -0600	[thread overview]
Message-ID: <4F20700B.8060307@sandeen.net> (raw)
In-Reply-To: <20120124174500.GB9853@infradead.org>

For some reason, non-xfs filesystems aren't getting mounted with
the selinux context; perhaps because none of the xattr tests used
to work on anything but xfs?

Anyway, 062 fails for extN unless we mount with the fs-wide
context.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

ps: eparis says this should work for NFS as well, let's go for
it and if infrequently tested filesystems have trouble we can
exclude them as necessary.

diff --git a/common.rc b/common.rc
index 6231457..602513a 100644
--- a/common.rc
+++ b/common.rc
@@ -72,11 +72,11 @@ _mount_opts()
     # nfs_t is a "liberal" context so we can use it.
     if [ -x /usr/sbin/selinuxenabled ] && /usr/sbin/selinuxenabled; then
 	SELINUX_MOUNT_OPTIONS="-o context=system_u:object_r:nfs_t:s0"
+	export SELINUX_MOUNT_OPTIONS
     fi
 
     case $FSTYP in
     xfs)
-	export SELINUX_MOUNT_OPTIONS
 	export MOUNT_OPTIONS=$XFS_MOUNT_OPTIONS
 	;;
     udf)


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-01-25 21:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 17:50 [PATCH] xfstests: mount other filesystems with selinux context as well Eric Sandeen
2011-11-23 17:50 ` Eric Sandeen
2011-11-28 11:02 ` Christoph Hellwig
2011-11-28 11:02   ` Christoph Hellwig
2012-01-19 18:37   ` Eric Sandeen
2012-01-19 18:37     ` Eric Sandeen
2012-01-24 17:45     ` Christoph Hellwig
2012-01-24 17:45       ` Christoph Hellwig
2012-01-25 21:11       ` Eric Sandeen [this message]
2012-01-25 21:11         ` [PATCH V2] " Eric Sandeen
2012-01-25 21:14         ` Christoph Hellwig
2012-01-25 21:14           ` Christoph Hellwig
2012-01-25 21:28           ` Eric Sandeen
2012-01-25 21:28             ` Eric Sandeen
2012-01-27 11:00             ` Christoph Hellwig
2012-01-27 11:00               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F20700B.8060307@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.