All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, joerg.roedel@amd.com,
	yoshikawa.takuya@oss.ntt.co.jp, mtosatti@redhat.com
Subject: Re: [PATCH v2 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch
Date: Mon, 30 Jan 2012 17:44:29 +0200	[thread overview]
Message-ID: <4F26BADD.7070800@redhat.com> (raw)
In-Reply-To: <4F26B68E.3030100@redhat.com>

On 01/30/2012 05:26 PM, Kevin Wolf wrote:
> > 
> > My bet is that it will be 3 if eflags.vm=1 and unchanged otherwise --
> > the cpl update happens when the segment cache is updated.  But that's
> > just a guess.
>
> Does even anyone see the new CPL in error cases? An exception is thrown
> immediately, so cs is reloaded and we get an even newer CPL. 

Depends on what we have on the IDT for the exception handler...

> So to take
> any notice of the CPL, the "complete the task switch" part would have to
> fail a privilege check. The one thing that comes to mind is that pushing
> an error code could fail, but I don't think this is considered part of
> the task switch.

Right.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-01-30 15:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 19:23 [PATCH v2 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-30 10:39   ` Avi Kivity
2012-01-30 11:12     ` Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 2/3] KVM: x86 emulator: VM86 segments must have DPL 3 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-30 10:24   ` Avi Kivity
2012-01-30 10:56     ` Gleb Natapov
2012-01-30 12:02       ` Avi Kivity
2012-01-30 12:04         ` Gleb Natapov
2012-01-30 13:24           ` Avi Kivity
2012-01-30 11:05     ` Kevin Wolf
2012-01-30 11:09       ` Gleb Natapov
2012-01-30 13:23       ` Avi Kivity
2012-01-30 14:01         ` Kevin Wolf
2012-01-30 14:32           ` Avi Kivity
2012-01-30 15:26             ` Kevin Wolf
2012-01-30 15:44               ` Avi Kivity [this message]
2012-01-30 15:55               ` Takuya Yoshikawa
2012-01-31  9:37               ` Gleb Natapov
2012-01-31 10:26                 ` Avi Kivity
2012-01-27 19:52 ` [PATCH v2 0/3] Fix task switches into/out of VM86 Gleb Natapov
2012-01-30  8:48   ` Kevin Wolf
2012-01-30  8:55     ` Gleb Natapov
2012-01-30 10:22       ` Gleb Natapov
2012-01-30 10:35       ` Kevin Wolf
2012-01-30 10:45         ` Avi Kivity
2012-01-30 10:50           ` Gleb Natapov
2012-01-30 11:59             ` Avi Kivity
2012-01-30 12:16               ` Gleb Natapov
2012-01-30 13:27                 ` Avi Kivity
2012-01-30 12:31               ` Gleb Natapov
2012-01-30 13:28                 ` Avi Kivity
2012-01-30 13:29                   ` Gleb Natapov
2012-01-30 13:39                     ` Avi Kivity
2012-01-30 10:47         ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F26BADD.7070800@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.