From: David Henningsson <david.henningsson@canonical.com>
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In
Date: Tue, 31 Jan 2012 11:18:38 +0100 [thread overview]
Message-ID: <4F27BFFE.6090400@canonical.com> (raw)
In-Reply-To: <CAN8ccibRNQAEopWKYdifHcsa84xDYsbH6KmTUWiQrR7o0PvHNA@mail.gmail.com>
On 01/31/2012 09:29 AM, Raymond Yau wrote:
> 2012/1/31, David Henningsson<david.henningsson@canonical.com>:
>> If a codec has both a front and a rear Line In, two controls both
>> named "Line Jack" will be created, which causes parsing to fail.
>> While a long term solution might be to name the jacks differently,
>> this extra check is consistent with what is already being done in many
>> auto-parsers, and will also protect against other cases when two
>> inputs have the same label.
>>
>> BugLink: https://bugs.launchpad.net/bugs/923409
>> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
>> ---
>
> I have doubt since most of ad1988 6stack-dig quirks have two Line In (
> one is ext front and the other is int ATAPI and the "Input Source"
> controls are broken
Well, it won't fix any "Input Source" controls, of course. Only jack
creation later, assuming you have your autocfg struct set up correctly.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
next prev parent reply other threads:[~2012-01-31 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 8:04 [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In David Henningsson
2012-01-31 8:29 ` Raymond Yau
2012-01-31 10:18 ` David Henningsson [this message]
2012-01-31 11:52 ` Raymond Yau
2012-01-31 14:17 ` Takashi Iwai
2012-01-31 15:28 ` David Henningsson
2012-01-31 15:40 ` Takashi Iwai
2012-02-01 8:19 ` David Henningsson
2012-02-01 8:39 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F27BFFE.6090400@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=superquad.vortex2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.