All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In
Date: Tue, 31 Jan 2012 16:28:14 +0100	[thread overview]
Message-ID: <4F28088E.5060203@canonical.com> (raw)
In-Reply-To: <s5hk448neh2.wl%tiwai@suse.de>

On 01/31/2012 03:17 PM, Takashi Iwai wrote:
> At Tue, 31 Jan 2012 09:04:15 +0100,
> David Henningsson wrote:
>>
>> If a codec has both a front and a rear Line In, two controls both
>> named "Line Jack" will be created, which causes parsing to fail.
>> While a long term solution might be to name the jacks differently,
>> this extra check is consistent with what is already being done in many
>> auto-parsers, and will also protect against other cases when two
>> inputs have the same label.
>>
>> BugLink: https://bugs.launchpad.net/bugs/923409
>> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
>
> Thanks, applied now.
>
> BTW, any chance to change apport to gather alsa-info.sh output?
> It'd be a great help, so that we can check it via hda-emu.

I have asked for this particular bug reporter to supply alsa-info as 
well, but may I ask you...do you have some kind of regression test 
script, and if so, are they public? Or could it a part of hda-emu?

It would be nice if you could run "make tests" or something from the 
hda-emu source directory, and it would parse all codecs and report error 
if parsing fails (or pm fails, etc).

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

  reply	other threads:[~2012-01-31 15:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  8:04 [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In David Henningsson
2012-01-31  8:29 ` Raymond Yau
2012-01-31 10:18   ` David Henningsson
2012-01-31 11:52     ` Raymond Yau
2012-01-31 14:17 ` Takashi Iwai
2012-01-31 15:28   ` David Henningsson [this message]
2012-01-31 15:40     ` Takashi Iwai
2012-02-01  8:19       ` David Henningsson
2012-02-01  8:39         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F28088E.5060203@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.