From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] gpio: pl061: enable interrupts with DT style binding
Date: Tue, 31 Jan 2012 08:44:19 -0600 [thread overview]
Message-ID: <4F27FE43.7090503@gmail.com> (raw)
In-Reply-To: <20120131143609.GA26436@S2101-09.ap.freescale.net>
On 01/31/2012 08:36 AM, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 11:31:39AM -0600, Rob Herring wrote:
> ...
>> -static void __init pl061_init_gc(struct pl061_gpio *chip, int irq_base)
>> +static void __init pl061_init_gc(struct pl061_gpio *chip,
>> + struct device_node *node, int irq_base)
>> {
>> struct irq_chip_type *ct;
>>
>> @@ -212,15 +212,17 @@ static void __init pl061_init_gc(struct pl061_gpio *chip, int irq_base)
>> ct->chip.irq_set_wake = irq_gc_set_wake;
>> ct->regs.mask = GPIOIE;
>>
>> - irq_setup_generic_chip(chip->irq_gc, IRQ_MSK(PL061_GPIO_NR),
>> - IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0);
>> + irq_setup_generic_chip_domain(chip->irq_gc, node,
>> + IRQ_MSK(PL061_GPIO_NR),
>> + IRQ_GC_INIT_NESTED_LOCK,
>> + IRQ_NOREQUEST, 0);
>> }
>
> The function irq_setup_generic_chip_domain() is wrapped by
> #ifdef CONFIG_IRQ_DOMAIN in patch #1. Is it true that pl061 driver
> will never work with !IRQ_DOMAIN case?
You're right unless Grant thinks IRQ_DOMAIN should always be enabled for
ARM? Otherwise, I'll add something like this for !IRQ_DOMAIN:
static inline void irq_setup_generic_chip_domain(
struct irq_chip_generic *gc,
struct device_node *node, u32 msk,
enum irq_gc_flags flags, unsigned int clr,
unsigned int set)
{
irq_setup_generic_chip(gc, msk, flags, clr, set);
}
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
b-cousson@ti.com, Linus Walleij <linus.ml.walleij@gmail.com>
Subject: Re: [PATCH v3 2/2] gpio: pl061: enable interrupts with DT style binding
Date: Tue, 31 Jan 2012 08:44:19 -0600 [thread overview]
Message-ID: <4F27FE43.7090503@gmail.com> (raw)
In-Reply-To: <20120131143609.GA26436@S2101-09.ap.freescale.net>
On 01/31/2012 08:36 AM, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 11:31:39AM -0600, Rob Herring wrote:
> ...
>> -static void __init pl061_init_gc(struct pl061_gpio *chip, int irq_base)
>> +static void __init pl061_init_gc(struct pl061_gpio *chip,
>> + struct device_node *node, int irq_base)
>> {
>> struct irq_chip_type *ct;
>>
>> @@ -212,15 +212,17 @@ static void __init pl061_init_gc(struct pl061_gpio *chip, int irq_base)
>> ct->chip.irq_set_wake = irq_gc_set_wake;
>> ct->regs.mask = GPIOIE;
>>
>> - irq_setup_generic_chip(chip->irq_gc, IRQ_MSK(PL061_GPIO_NR),
>> - IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0);
>> + irq_setup_generic_chip_domain(chip->irq_gc, node,
>> + IRQ_MSK(PL061_GPIO_NR),
>> + IRQ_GC_INIT_NESTED_LOCK,
>> + IRQ_NOREQUEST, 0);
>> }
>
> The function irq_setup_generic_chip_domain() is wrapped by
> #ifdef CONFIG_IRQ_DOMAIN in patch #1. Is it true that pl061 driver
> will never work with !IRQ_DOMAIN case?
You're right unless Grant thinks IRQ_DOMAIN should always be enabled for
ARM? Otherwise, I'll add something like this for !IRQ_DOMAIN:
static inline void irq_setup_generic_chip_domain(
struct irq_chip_generic *gc,
struct device_node *node, u32 msk,
enum irq_gc_flags flags, unsigned int clr,
unsigned int set)
{
irq_setup_generic_chip(gc, msk, flags, clr, set);
}
Rob
next prev parent reply other threads:[~2012-01-31 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:31 [PATCH v3 0/2] generic irq chip and pl061 domain support Rob Herring
2012-01-30 17:31 ` Rob Herring
2012-01-30 17:31 ` [PATCH v3 1/2] irq: add irq_domain support to generic-chip Rob Herring
2012-01-30 17:31 ` Rob Herring
2012-01-31 14:13 ` Shawn Guo
2012-01-31 14:13 ` Shawn Guo
2012-01-31 14:32 ` Rob Herring
2012-01-31 14:32 ` Rob Herring
2012-01-31 15:06 ` Shawn Guo
2012-01-31 15:06 ` Shawn Guo
2012-01-31 15:37 ` Rob Herring
2012-01-31 15:37 ` Rob Herring
2012-02-01 0:02 ` Grant Likely
2012-02-01 0:02 ` Grant Likely
2012-01-30 17:31 ` [PATCH v3 2/2] gpio: pl061: enable interrupts with DT style binding Rob Herring
2012-01-30 17:31 ` Rob Herring
2012-01-31 14:36 ` Shawn Guo
2012-01-31 14:36 ` Shawn Guo
2012-01-31 14:44 ` Rob Herring [this message]
2012-01-31 14:44 ` Rob Herring
2012-02-01 0:07 ` Grant Likely
2012-02-01 0:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F27FE43.7090503@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.