From: Huang Shijie <b32955@freescale.com>
To: Huang Shijie <b32955@freescale.com>
Cc: vinod.koul@intel.com, shawn.guo@linaro.org,
artem.bityutskiy@intel.com, shijie8@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, w.sang@pengutronix.de,
LW@KARO-electronics.de, alsa-devel@alsa-project.org,
b29396@freescale.com
Subject: Re: [PATCH v2 0/2] patch set about the MXS-DMA
Date: Wed, 1 Feb 2012 10:21:35 +0800 [thread overview]
Message-ID: <4F28A1AF.8040402@freescale.com> (raw)
In-Reply-To: <1327044818-4464-1-git-send-email-b32955@freescale.com>
hi,
> patch 1: move the mxs dma header to a more common place.
> Beside the mx23/mx28, the apbh-dma is also used by MX50 and MX6Q.
> So move the mxs dma header file to a more common place, and rename
> it to mxs-dma.h
>
> patch 2: rewrite the last parameter of mxs_dma_prep_slave_sg().
> In the new GPMI version, some hardware behavior changes.
> The WAIT4END bit should be set in the middle one of the ECC READ page DMA chain.
> The DMA chain should be set like this:
>
> +-----+ +-----+ +-----+
> | cmd | ------------> | cmd | ------------------> | cmd |
> +-----+ +-----+ +-----+
> ^ ^
> | |
> | |
> set WAIT4END here too set WAIT4END here
>
> So rewrite the last parameter of mxs_dma_prep_slave_sg(), use the
> dma_ctrl_flags to set the proper DMA bit for DMA Command Structure.
> And change the relative drivers with the dma_ctrl_flags.
>
> TEST:
> Tested the mxs-mmc driver and gpmi-nand drive with the two patches
> in MX28 board.
>
> v1 --> v2:
> [1] squash the trial patches into single patch.
> [2] use the dma_ctrl_flags.
>
> Huang Shijie (2):
> mxs-dma : move the mxs dma.h to a more common place
> mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg()
>
> drivers/dma/mxs-dma.c | 34 +++++++++++++++++---
> drivers/mmc/host/mxs-mmc.c | 12 +++---
> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 28 +++++++++++++---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 6 +++-
> drivers/mtd/nand/gpmi-nand/gpmi-regs.h | 2 +
> .../include/mach/dma.h => include/linux/mxs-dma.h | 0
> sound/soc/mxs/mxs-pcm.c | 2 +-
> sound/soc/mxs/mxs-pcm.h | 2 +-
> sound/soc/mxs/mxs-saif.c | 2 +-
> 9 files changed, 67 insertions(+), 21 deletions(-)
> rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)
>
ping.
Could these two patches ok ?
My following patches depend upon them.
BR
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Huang Shijie <b32955@freescale.com>
Cc: alsa-devel@alsa-project.org, artem.bityutskiy@intel.com,
vinod.koul@intel.com, b29396@freescale.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
w.sang@pengutronix.de, linux-mtd@lists.infradead.org,
shawn.guo@linaro.org, shijie8@gmail.com,
linux-arm-kernel@lists.infradead.org, LW@KARO-electronics.de
Subject: Re: [PATCH v2 0/2] patch set about the MXS-DMA
Date: Wed, 1 Feb 2012 10:21:35 +0800 [thread overview]
Message-ID: <4F28A1AF.8040402@freescale.com> (raw)
In-Reply-To: <1327044818-4464-1-git-send-email-b32955@freescale.com>
hi,
> patch 1: move the mxs dma header to a more common place.
> Beside the mx23/mx28, the apbh-dma is also used by MX50 and MX6Q.
> So move the mxs dma header file to a more common place, and rename
> it to mxs-dma.h
>
> patch 2: rewrite the last parameter of mxs_dma_prep_slave_sg().
> In the new GPMI version, some hardware behavior changes.
> The WAIT4END bit should be set in the middle one of the ECC READ page DMA chain.
> The DMA chain should be set like this:
>
> +-----+ +-----+ +-----+
> | cmd | ------------> | cmd | ------------------> | cmd |
> +-----+ +-----+ +-----+
> ^ ^
> | |
> | |
> set WAIT4END here too set WAIT4END here
>
> So rewrite the last parameter of mxs_dma_prep_slave_sg(), use the
> dma_ctrl_flags to set the proper DMA bit for DMA Command Structure.
> And change the relative drivers with the dma_ctrl_flags.
>
> TEST:
> Tested the mxs-mmc driver and gpmi-nand drive with the two patches
> in MX28 board.
>
> v1 --> v2:
> [1] squash the trial patches into single patch.
> [2] use the dma_ctrl_flags.
>
> Huang Shijie (2):
> mxs-dma : move the mxs dma.h to a more common place
> mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg()
>
> drivers/dma/mxs-dma.c | 34 +++++++++++++++++---
> drivers/mmc/host/mxs-mmc.c | 12 +++---
> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 28 +++++++++++++---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 6 +++-
> drivers/mtd/nand/gpmi-nand/gpmi-regs.h | 2 +
> .../include/mach/dma.h => include/linux/mxs-dma.h | 0
> sound/soc/mxs/mxs-pcm.c | 2 +-
> sound/soc/mxs/mxs-pcm.h | 2 +-
> sound/soc/mxs/mxs-saif.c | 2 +-
> 9 files changed, 67 insertions(+), 21 deletions(-)
> rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)
>
ping.
Could these two patches ok ?
My following patches depend upon them.
BR
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] patch set about the MXS-DMA
Date: Wed, 1 Feb 2012 10:21:35 +0800 [thread overview]
Message-ID: <4F28A1AF.8040402@freescale.com> (raw)
In-Reply-To: <1327044818-4464-1-git-send-email-b32955@freescale.com>
hi,
> patch 1: move the mxs dma header to a more common place.
> Beside the mx23/mx28, the apbh-dma is also used by MX50 and MX6Q.
> So move the mxs dma header file to a more common place, and rename
> it to mxs-dma.h
>
> patch 2: rewrite the last parameter of mxs_dma_prep_slave_sg().
> In the new GPMI version, some hardware behavior changes.
> The WAIT4END bit should be set in the middle one of the ECC READ page DMA chain.
> The DMA chain should be set like this:
>
> +-----+ +-----+ +-----+
> | cmd | ------------> | cmd | ------------------> | cmd |
> +-----+ +-----+ +-----+
> ^ ^
> | |
> | |
> set WAIT4END here too set WAIT4END here
>
> So rewrite the last parameter of mxs_dma_prep_slave_sg(), use the
> dma_ctrl_flags to set the proper DMA bit for DMA Command Structure.
> And change the relative drivers with the dma_ctrl_flags.
>
> TEST:
> Tested the mxs-mmc driver and gpmi-nand drive with the two patches
> in MX28 board.
>
> v1 --> v2:
> [1] squash the trial patches into single patch.
> [2] use the dma_ctrl_flags.
>
> Huang Shijie (2):
> mxs-dma : move the mxs dma.h to a more common place
> mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg()
>
> drivers/dma/mxs-dma.c | 34 +++++++++++++++++---
> drivers/mmc/host/mxs-mmc.c | 12 +++---
> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 28 +++++++++++++---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 6 +++-
> drivers/mtd/nand/gpmi-nand/gpmi-regs.h | 2 +
> .../include/mach/dma.h => include/linux/mxs-dma.h | 0
> sound/soc/mxs/mxs-pcm.c | 2 +-
> sound/soc/mxs/mxs-pcm.h | 2 +-
> sound/soc/mxs/mxs-saif.c | 2 +-
> 9 files changed, 67 insertions(+), 21 deletions(-)
> rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)
>
ping.
Could these two patches ok ?
My following patches depend upon them.
BR
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Huang Shijie <b32955@freescale.com>
Cc: <vinod.koul@intel.com>, <shawn.guo@linaro.org>,
<artem.bityutskiy@intel.com>, <shijie8@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mtd@lists.infradead.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <w.sang@pengutronix.de>,
<LW@KARO-electronics.de>, <alsa-devel@alsa-project.org>,
<b29396@freescale.com>
Subject: Re: [PATCH v2 0/2] patch set about the MXS-DMA
Date: Wed, 1 Feb 2012 10:21:35 +0800 [thread overview]
Message-ID: <4F28A1AF.8040402@freescale.com> (raw)
In-Reply-To: <1327044818-4464-1-git-send-email-b32955@freescale.com>
hi,
> patch 1: move the mxs dma header to a more common place.
> Beside the mx23/mx28, the apbh-dma is also used by MX50 and MX6Q.
> So move the mxs dma header file to a more common place, and rename
> it to mxs-dma.h
>
> patch 2: rewrite the last parameter of mxs_dma_prep_slave_sg().
> In the new GPMI version, some hardware behavior changes.
> The WAIT4END bit should be set in the middle one of the ECC READ page DMA chain.
> The DMA chain should be set like this:
>
> +-----+ +-----+ +-----+
> | cmd | ------------> | cmd | ------------------> | cmd |
> +-----+ +-----+ +-----+
> ^ ^
> | |
> | |
> set WAIT4END here too set WAIT4END here
>
> So rewrite the last parameter of mxs_dma_prep_slave_sg(), use the
> dma_ctrl_flags to set the proper DMA bit for DMA Command Structure.
> And change the relative drivers with the dma_ctrl_flags.
>
> TEST:
> Tested the mxs-mmc driver and gpmi-nand drive with the two patches
> in MX28 board.
>
> v1 --> v2:
> [1] squash the trial patches into single patch.
> [2] use the dma_ctrl_flags.
>
> Huang Shijie (2):
> mxs-dma : move the mxs dma.h to a more common place
> mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg()
>
> drivers/dma/mxs-dma.c | 34 +++++++++++++++++---
> drivers/mmc/host/mxs-mmc.c | 12 +++---
> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 28 +++++++++++++---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 6 +++-
> drivers/mtd/nand/gpmi-nand/gpmi-regs.h | 2 +
> .../include/mach/dma.h => include/linux/mxs-dma.h | 0
> sound/soc/mxs/mxs-pcm.c | 2 +-
> sound/soc/mxs/mxs-pcm.h | 2 +-
> sound/soc/mxs/mxs-saif.c | 2 +-
> 9 files changed, 67 insertions(+), 21 deletions(-)
> rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)
>
ping.
Could these two patches ok ?
My following patches depend upon them.
BR
Huang Shijie
next prev parent reply other threads:[~2012-02-01 2:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 7:33 [PATCH v2 0/2] patch set about the MXS-DMA Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` [PATCH v2 1/2] mxs-dma : move the mxs dma.h to a more common place Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` [PATCH v2 2/2] mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg() Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-01-20 7:33 ` Huang Shijie
2012-02-03 1:57 ` Huang Shijie
2012-02-03 1:57 ` Huang Shijie
2012-02-03 1:57 ` Huang Shijie
2012-02-03 1:57 ` Huang Shijie
2012-02-01 2:21 ` Huang Shijie [this message]
2012-02-01 2:21 ` [PATCH v2 0/2] patch set about the MXS-DMA Huang Shijie
2012-02-01 2:21 ` Huang Shijie
2012-02-01 2:21 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F28A1AF.8040402@freescale.com \
--to=b32955@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=artem.bityutskiy@intel.com \
--cc=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
--cc=vinod.koul@intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.