From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <paulmck@linux.vnet.ibm.com>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
ben@decadent.org.uk
Subject: Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
Date: Wed, 1 Feb 2012 15:28:34 -0500 [thread overview]
Message-ID: <4F29A072.9050203@windriver.com> (raw)
In-Reply-To: <20120201185510.GA8542@linux.vnet.ibm.com>
On 12-02-01 01:55 PM, Paul E. McKenney wrote:
> The variable cpus_in_crash gets a defined-but-not-used warning when
> CONFIG_SMP=n, so fix by placing the variable under ifdef.
I think Ben already merged a similar fix.
http://patchwork.ozlabs.org/patch/136549/
P.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 28be345..eb3384e 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -46,7 +46,9 @@
>
> /* This keeps a track of which one is the crashing cpu. */
> int crashing_cpu = -1;
> +#ifdef CONFIG_SMP
> static atomic_t cpus_in_crash;
> +#endif /* #ifdef CONFIG_SMP */
> static int time_to_dump;
>
> #define CRASH_HANDLER_MAX 3
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <paulmck@linux.vnet.ibm.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<paulus@samba.org>, <anton@samba.org>, <ben@decadent.org.uk>,
<mikey@neuling.org>
Subject: Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
Date: Wed, 1 Feb 2012 15:28:34 -0500 [thread overview]
Message-ID: <4F29A072.9050203@windriver.com> (raw)
In-Reply-To: <20120201185510.GA8542@linux.vnet.ibm.com>
On 12-02-01 01:55 PM, Paul E. McKenney wrote:
> The variable cpus_in_crash gets a defined-but-not-used warning when
> CONFIG_SMP=n, so fix by placing the variable under ifdef.
I think Ben already merged a similar fix.
http://patchwork.ozlabs.org/patch/136549/
P.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 28be345..eb3384e 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -46,7 +46,9 @@
>
> /* This keeps a track of which one is the crashing cpu. */
> int crashing_cpu = -1;
> +#ifdef CONFIG_SMP
> static atomic_t cpus_in_crash;
> +#endif /* #ifdef CONFIG_SMP */
> static int time_to_dump;
>
> #define CRASH_HANDLER_MAX 3
>
next prev parent reply other threads:[~2012-02-01 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 18:55 [PATCH] powerpc: Define cpus_in_crash only for SMP kernels Paul E. McKenney
2012-02-01 18:55 ` Paul E. McKenney
2012-02-01 20:28 ` Paul Gortmaker [this message]
2012-02-01 20:28 ` Paul Gortmaker
2012-02-01 23:15 ` Paul E. McKenney
2012-02-01 23:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29A072.9050203@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=anton@samba.org \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.