* [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table
@ 2012-02-02 15:27 Moger, Babu
2012-02-02 17:43 ` [dm-devel] " Hannes Reinecke
0 siblings, 1 reply; 3+ messages in thread
From: Moger, Babu @ 2012-02-02 15:27 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org; +Cc: device-mapper development
Resubmitting it again(Probably last one had some format issues).
Adding all the definitions of host bytes in hostbyte_table.
Without this patch, scsi_show_result prints hostbyte as invalid
for statuses that are not defined in hostbyte_table(when scsi logging is enabled).
Look at scsi_print_result function for better understanding.
Signed-off-by: Babu Moger <babu.moger@netapp.com>
---
--- linux-3.1-rc4/drivers/scsi/constants.c.orig 2012-01-12 15:21:28.000000000 -0600
+++ linux-3.1-rc4/drivers/scsi/constants.c 2012-01-12 15:25:07.000000000 -0600
@@ -1422,7 +1422,8 @@ static const char * const hostbyte_table
"DID_OK", "DID_NO_CONNECT", "DID_BUS_BUSY", "DID_TIME_OUT", "DID_BAD_TARGET",
"DID_ABORT", "DID_PARITY", "DID_ERROR", "DID_RESET", "DID_BAD_INTR",
"DID_PASSTHROUGH", "DID_SOFT_ERROR", "DID_IMM_RETRY", "DID_REQUEUE",
-"DID_TRANSPORT_DISRUPTED", "DID_TRANSPORT_FAILFAST" };
+"DID_TRANSPORT_DISRUPTED", "DID_TRANSPORT_FAILFAST", "DID_TARGET_FAILURE",
+"DID_NEXUS_FAILURE" };
#define NUM_HOSTBYTE_STRS ARRAY_SIZE(hostbyte_table)
static const char * const driverbyte_table[]={
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dm-devel] [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table
2012-02-02 15:27 [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table Moger, Babu
@ 2012-02-02 17:43 ` Hannes Reinecke
0 siblings, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2012-02-02 17:43 UTC (permalink / raw)
To: device-mapper development; +Cc: Moger, Babu, linux-kernel@vger.kernel.org
On 02/02/2012 04:27 PM, Moger, Babu wrote:
> Resubmitting it again(Probably last one had some format issues).
> Adding all the definitions of host bytes in hostbyte_table.
>
> Without this patch, scsi_show_result prints hostbyte as invalid
> for statuses that are not defined in hostbyte_table(when scsi logging is enabled).
>
> Look at scsi_print_result function for better understanding.
>
> Signed-off-by: Babu Moger<babu.moger@netapp.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table
@ 2012-07-27 17:28 Moger, Babu
2012-07-30 6:15 ` [dm-devel] " Hannes Reinecke
0 siblings, 1 reply; 3+ messages in thread
From: Moger, Babu @ 2012-07-27 17:28 UTC (permalink / raw)
To: linux-scsi
Cc: device-mapper development (dm-devel@redhat.com),
James.Bottomley@hansenpartnership.com
Submitted this patch earlier. But it still did not make it to kernel tree.
Resubmitting again(recreated on top of 3.5 kernel).
Adding all the definitions of host bytes in hostbyte_table.
Without this patch, scsi_show_result prints hostbyte as invalid
for statuses that are not defined in hostbyte_table(when scsi logging is enabled).
Look at scsi_print_result function for better understanding.
Signed-off-by: Babu Moger <babu.moger@netapp.com>
---
--- linux-3.5-rc7/drivers/scsi/constants.c.orig 2012-07-27 13:02:28.000000000 -0500
+++ linux-3.5-rc7/drivers/scsi/constants.c 2012-07-27 13:03:26.000000000 -0500
@@ -1422,7 +1422,8 @@ static const char * const hostbyte_table
"DID_OK", "DID_NO_CONNECT", "DID_BUS_BUSY", "DID_TIME_OUT", "DID_BAD_TARGET",
"DID_ABORT", "DID_PARITY", "DID_ERROR", "DID_RESET", "DID_BAD_INTR",
"DID_PASSTHROUGH", "DID_SOFT_ERROR", "DID_IMM_RETRY", "DID_REQUEUE",
-"DID_TRANSPORT_DISRUPTED", "DID_TRANSPORT_FAILFAST" };
+"DID_TRANSPORT_DISRUPTED", "DID_TRANSPORT_FAILFAST", "DID_TARGET_FAILURE",
+"DID_NEXUS_FAILURE" };
#define NUM_HOSTBYTE_STRS ARRAY_SIZE(hostbyte_table)
static const char * const driverbyte_table[]={
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dm-devel] [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table
2012-07-27 17:28 Moger, Babu
@ 2012-07-30 6:15 ` Hannes Reinecke
0 siblings, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2012-07-30 6:15 UTC (permalink / raw)
To: device-mapper development; +Cc: Moger, Babu, linux-scsi
On 07/27/2012 07:28 PM, Moger, Babu wrote:
> Submitted this patch earlier. But it still did not make it to kernel tree.
> Resubmitting again(recreated on top of 3.5 kernel).
>
> Adding all the definitions of host bytes in hostbyte_table.
>
> Without this patch, scsi_show_result prints hostbyte as invalid
> for statuses that are not defined in hostbyte_table(when scsi logging is enabled).
>
> Look at scsi_print_result function for better understanding.
>
> Signed-off-by: Babu Moger <babu.moger@netapp.com>
Acked-by: Hannes Reinecke <hare@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-30 6:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-02 15:27 [PATCH] scsi : Adding all the definitions of host bytes in hostbyte_table Moger, Babu
2012-02-02 17:43 ` [dm-devel] " Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2012-07-27 17:28 Moger, Babu
2012-07-30 6:15 ` [dm-devel] " Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.