All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Discuss
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	U-Boot Mailing List
	<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
	Jerry Van Baren
	<vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>,
	Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Albert ARIBAUD
	<albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org>
Subject: Re: [PATCH v5 08/18] tegra: fdt: Add additional USB binding
Date: Thu, 02 Feb 2012 14:55:07 -0700	[thread overview]
Message-ID: <4F2B063B.2020403@nvidia.com> (raw)
In-Reply-To: <1327447272-30182-9-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On 01/24/2012 04:21 PM, Simon Glass wrote:
> This adds a property to indicate a port which can switch between host and device
> mode.
...
> diff --git a/doc/device-tree-bindings/usb/tegra-usb.txt b/doc/device-tree-bindings/usb/tegra-usb.txt
...
> +Optional properties:
...
> +  - nvidia,has-legacy-mode : boolean indicates whether this controller can
> +    operate in legacy mode (as APX 2500 / 2600). In legacy mode some
> +    registers are accessed through the APB_MISC base address instead of
> +    the USB controller.

I was hoping to represent this as a different compatible value, in the
same way as one of Tegra's I2C controllers is, eg. nvidia,tegra20-ehci
and nvidia,tegra20-ehci-legacy.

However, I suppose representing this using a property is OK too.

Either way, can you please also push this patch to the Linux kernel (and
the associated changes to tegra*.dtsi) in order to run it past the other
Tegra maintainers before committing to it within U-Boot.

Thanks.

-- 
nvpublic

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 08/18] tegra: fdt: Add additional USB binding
Date: Thu, 02 Feb 2012 14:55:07 -0700	[thread overview]
Message-ID: <4F2B063B.2020403@nvidia.com> (raw)
In-Reply-To: <1327447272-30182-9-git-send-email-sjg@chromium.org>

On 01/24/2012 04:21 PM, Simon Glass wrote:
> This adds a property to indicate a port which can switch between host and device
> mode.
...
> diff --git a/doc/device-tree-bindings/usb/tegra-usb.txt b/doc/device-tree-bindings/usb/tegra-usb.txt
...
> +Optional properties:
...
> +  - nvidia,has-legacy-mode : boolean indicates whether this controller can
> +    operate in legacy mode (as APX 2500 / 2600). In legacy mode some
> +    registers are accessed through the APB_MISC base address instead of
> +    the USB controller.

I was hoping to represent this as a different compatible value, in the
same way as one of Tegra's I2C controllers is, eg. nvidia,tegra20-ehci
and nvidia,tegra20-ehci-legacy.

However, I suppose representing this using a property is OK too.

Either way, can you please also push this patch to the Linux kernel (and
the associated changes to tegra*.dtsi) in order to run it past the other
Tegra maintainers before committing to it within U-Boot.

Thanks.

-- 
nvpublic

  parent reply	other threads:[~2012-02-02 21:55 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24 23:20 [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver Simon Glass
     [not found] ` <1327447272-30182-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-24 23:20   ` [PATCH v5 01/18] fdt: Add basic support for decoding GPIO definitions Simon Glass
2012-01-24 23:20     ` [U-Boot] " Simon Glass
2012-01-24 23:20   ` [PATCH v5 02/18] arm: fdt: Ensure that an embedded fdt is word-aligned Simon Glass
2012-01-24 23:20     ` [U-Boot] " Simon Glass
2012-01-24 23:20   ` [PATCH v5 03/18] arm: fdt: Add skeleton device tree file from kernel Simon Glass
2012-01-24 23:20     ` [U-Boot] " Simon Glass
2012-01-24 23:20   ` [PATCH v5 04/18] tegra: fdt: Add Tegra2x " Simon Glass
2012-01-24 23:20     ` [U-Boot] " Simon Glass
2012-01-24 23:20   ` [PATCH v5 05/18] tegra: fdt: Add device tree file for Tegra2 Seaboard " Simon Glass
2012-01-24 23:20     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 06/18] fdt: Add staging area for device tree binding documentation Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 07/18] fdt: Add tegra-usb bindings file from linux Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 08/18] tegra: fdt: Add additional USB binding Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
     [not found]     ` <1327447272-30182-9-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 21:55       ` Stephen Warren [this message]
2012-02-02 21:55         ` Stephen Warren
     [not found]         ` <4F2B063B.2020403-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-03 16:58           ` Simon Glass
2012-02-03 16:58             ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 09/18] tegra: fdt: Add clock bindings Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 10/18] tegra: usb: fdt: Add additional device tree definitions for USB ports Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
     [not found]     ` <1327447272-30182-11-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 22:07       ` Stephen Warren
2012-02-02 22:07         ` [U-Boot] " Stephen Warren
2012-02-03 17:04         ` Simon Glass
2012-02-03 17:04           ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 11/18] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 13/18] fdt: Add function to return peripheral/clock ID Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
2012-01-24 23:21   ` [PATCH v5 18/18] tegra: fdt: Enable FDT support for Seaboard Simon Glass
2012-01-24 23:21     ` [U-Boot] " Simon Glass
     [not found]     ` <1327447272-30182-19-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 22:17       ` Stephen Warren
2012-02-02 22:17         ` [U-Boot] " Stephen Warren
2012-02-03 17:05         ` Simon Glass
2012-02-03 17:05           ` [U-Boot] " Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 12/18] usb: Add support for txfifo threshold Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 14/18] tegra: usb: Add support for Tegra USB peripheral Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 15/18] tegra: usb: Add USB support to nvidia boards Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 16/18] tegra: usb: Add common USB defines for tegra2 boards Simon Glass
2012-01-24 23:21 ` [U-Boot] [PATCH v5 17/18] tegra: usb: Enable USB on Seaboard Simon Glass
2012-02-26 23:13 ` [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver Marek Vasut
2012-02-27  3:02   ` Simon Glass
2012-02-27 20:49     ` Simon Glass
2012-02-27 20:55       ` Marek Vasut
2012-02-27 21:44         ` Tom Warren
2012-02-27 21:46           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2B063B.2020403@nvidia.com \
    --to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
    --cc=vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.