From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <leoli@freescale.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: [RFC] Multi queue support in ethernet/freescale/ucc_geth.c
Date: Thu, 2 Feb 2012 17:42:00 -0500 [thread overview]
Message-ID: <4F2B1138.2090004@windriver.com> (raw)
Hi Li,
A while back DaveM mentioned that it would be good to
break out the ring allocations[1] in this driver.
I was looking at it, and in the process noticed this:
$ grep 'numQueues.*=' drivers/net/ethernet/freescale/ucc_geth.c
.numQueuesTx = 1,
.numQueuesRx = 1,
$
My interpretation of the above is that there is no way
(aside from a code edit) to enable multi queue support.
They are only ever assigned one time, to a value of one.
Assuming I'm not missing something obvious, is the multi
queue support functional and tested, or just old code
that never got tested and subsequently enabled?
The reason I ask, is that the ring allocation code gets rid
of the loop wrapping it, if the driver is really only meant
to ever have just single queues for Rx/Tx. And other areas
of the driver can also be simplified accordingly as well.
Thanks,
Paul.
[1] http://lists.openwall.net/netdev/2010/09/06/45
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <leoli@freescale.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>
Subject: [RFC] Multi queue support in ethernet/freescale/ucc_geth.c
Date: Thu, 2 Feb 2012 17:42:00 -0500 [thread overview]
Message-ID: <4F2B1138.2090004@windriver.com> (raw)
Hi Li,
A while back DaveM mentioned that it would be good to
break out the ring allocations[1] in this driver.
I was looking at it, and in the process noticed this:
$ grep 'numQueues.*=' drivers/net/ethernet/freescale/ucc_geth.c
.numQueuesTx = 1,
.numQueuesRx = 1,
$
My interpretation of the above is that there is no way
(aside from a code edit) to enable multi queue support.
They are only ever assigned one time, to a value of one.
Assuming I'm not missing something obvious, is the multi
queue support functional and tested, or just old code
that never got tested and subsequently enabled?
The reason I ask, is that the ring allocation code gets rid
of the loop wrapping it, if the driver is really only meant
to ever have just single queues for Rx/Tx. And other areas
of the driver can also be simplified accordingly as well.
Thanks,
Paul.
[1] http://lists.openwall.net/netdev/2010/09/06/45
next reply other threads:[~2012-02-03 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 22:42 Paul Gortmaker [this message]
2012-02-02 22:42 ` [RFC] Multi queue support in ethernet/freescale/ucc_geth.c Paul Gortmaker
2012-02-09 10:44 ` Li Yang-R58472
2012-02-09 10:44 ` Li Yang-R58472
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2B1138.2090004@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.