[PATCH] Fix format-security compile warnings/errors

[PATCH] Fix format-security compile warnings/errors

[Richard Laager]

[-- Attachment #1.1: Type: text/plain, Size: 173 bytes --]

The attached trivial patch fixes a couple of format-security
warnings/errors (if -Werror=format-security is set, as is becoming more
popular on distros).

-- 
Richard

[-- Attachment #1.2: compile-warnings.patch --]
[-- Type: text/x-patch, Size: 1409 bytes --]

Index: grub/util/grub-mkimage.c
===================================================================
--- grub.orig/util/grub-mkimage.c	2012-01-31 00:31:31.409215919 -0600
+++ grub/util/grub-mkimage.c	2012-01-31 00:31:42.060047000 -0600
@@ -1821,7 +1821,7 @@
 
   if (!image_target)
     {
-      printf (_("Target format not specified (use the -O option).\n"));
+      printf ("%s", _("Target format not specified (use the -O option).\n"));
       usage (1);
     }
 
Index: grub/util/grub-mkrelpath.c
===================================================================
--- grub.orig/util/grub-mkrelpath.c	2012-01-31 00:31:34.493209927 -0600
+++ grub/util/grub-mkrelpath.c	2012-01-31 00:31:49.276858000 -0600
@@ -89,7 +89,7 @@
 
   if (optind >= argc)
     {
-      fprintf (stderr, _("No path is specified.\n"));
+      fprintf (stderr, "%s", _("No path is specified.\n"));
       usage (1);
     }
 
Index: grub/util/grub-probe.c
===================================================================
--- grub.orig/util/grub-probe.c	2012-01-31 00:32:06.329166567 -0600
+++ grub/util/grub-probe.c	2012-01-31 00:32:12.627705000 -0600
@@ -746,7 +746,7 @@
   /* Obtain ARGUMENT.  */
   if (optind >= argc)
     {
-      fprintf (stderr, _("No path or device is specified.\n"));
+      fprintf (stderr, "%s", _("No path or device is specified.\n"));
       usage (1);
     }
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Fix format-security compile warnings/errors

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 01.02.2012 07:45, Richard Laager wrote:
> The attached trivial patch fixes a couple of format-security
> warnings/errors (if -Werror=format-security is set, as is becoming more
> popular on distros).
>
Committed, thanks
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Re: [PATCH] Fix format-security compile warnings/errors

[Richard Laager]

[-- Attachment #1.1: Type: text/plain, Size: 87 bytes --]

You introduced another one of these in revision 3830. Patch attached.

-- 
Richard

[-- Attachment #1.2: xnu-compile-warning.patch --]
[-- Type: text/x-patch, Size: 554 bytes --]

Index: grub/grub-core/loader/i386/xnu.c
===================================================================
--- grub.orig/grub-core/loader/i386/xnu.c	2012-02-04 14:44:04.022918008 -0600
+++ grub/grub-core/loader/i386/xnu.c	2012-02-04 14:44:36.726267000 -0600
@@ -1003,7 +1003,7 @@ grub_xnu_boot (void)
 
   if (debug && (grub_strword (debug, "all") || grub_strword (debug, "xnu")))
     {
-      grub_printf (_("Press any key to launch xnu\n"));
+      grub_printf ("%s", _("Press any key to launch xnu\n"));
       grub_getkey ();
     }
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]