[PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

[PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

[Jonas Gorski]

bcm63xx_gpio.h uses macros defined in bcm63xx_cpu.h without including it,
leading to the following build failure:

  CC [M]  drivers/mmc/core/cd-gpio.o
In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
                 from arch/mips/include/asm/gpio.h:4,
                 from include/linux/gpio.h:30,
                 from drivers/mmc/core/cd-gpio.c:12:

arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 'bcm63xx_gpio_count':
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit declaration of function 'bcm63xx_get_cpu_id'
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' undeclared (first use in this function)

make[7]: *** [drivers/mmc/core/cd-gpio.o] Error 1

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---

Looking at the file's history, it looks like the problem was there from
the beginning. So it probably should go into all supported (stable)
versions up to 3.3-rc2, even if this particular build failure popped up
first in 3.3.

 arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
index 3d5de96..1d7dd96 100644
--- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
+++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
@@ -2,6 +2,7 @@
 #define BCM63XX_GPIO_H
 
 #include <linux/init.h>
+#include <bcm63xx_cpu.h>
 
 int __init bcm63xx_gpio_init(void);
 
-- 
1.7.2.5

Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

[Sergei Shtylyov]

Hello.

On 03-02-2012 0:52, Jonas Gorski wrote:

> bcm63xx_gpio.h uses macros defined in bcm63xx_cpu.h without including it,
> leading to the following build failure:

>    CC [M]  drivers/mmc/core/cd-gpio.o
> In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
>                   from arch/mips/include/asm/gpio.h:4,
>                   from include/linux/gpio.h:30,
>                   from drivers/mmc/core/cd-gpio.c:12:

> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 'bcm63xx_gpio_count':
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit declaration of function 'bcm63xx_get_cpu_id'
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared identifier is reported only once for each function it appears in
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' undeclared (first use in this function)

> make[7]: *** [drivers/mmc/core/cd-gpio.o] Error 1

> Signed-off-by: Jonas Gorski<jonas.gorski@gmail.com>
> ---

> Looking at the file's history, it looks like the problem was there from
> the beginning. So it probably should go into all supported (stable)
> versions up to 3.3-rc2, even if this particular build failure popped up
> first in 3.3.

    You should then addd "Cc: stable@vger.kernel.org" line after your signoff.

WBR, Sergei

Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

[Jonas Gorski]

Hi,

On 3 February 2012 11:25, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
>   You should then addd "Cc: stable@vger.kernel.org" line after your signoff.

Hrm, somehow I misremember this is supposed to be done only after the
patch got accepted. You are (mostly) right, only the address is now
stable@kernel.org :) I'll resend shortly.

a bit more confused than usually,
Jonas

Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

[Sergei Shtylyov]

Hello.

On 03-02-2012 15:17, Jonas Gorski wrote:

>>    You should then addd "Cc: stable@vger.kernel.org" line after your signoff.

> Hrm, somehow I misremember this is supposed to be done only after the
> patch got accepted. You are (mostly) right, only the address is now
> stable@kernel.org :) I'll resend shortly.

    I heard the contrary -- that it was stable@kernel.org and now 
stable@vger.kernel.org.

> a bit more confused than usually,
> Jonas

WBR, Sergei