[Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Jan Kiszka]

-Werror-implicit-function-declaration is not compatible with C++, and
also decisions about -Wall and -pipe should be left to the application.

Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
---
 configure.in |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/configure.in b/configure.in
index b2563ee..2185925 100644
--- a/configure.in
+++ b/configure.in
@@ -448,13 +448,13 @@ else
 fi
 AC_MSG_RESULT([done])
 
-dnl Common CFLAGS and LDFLAGS
-XENO_USER_CFLAGS="-D_GNU_SOURCE -D_REENTRANT -Wall -Werror-implicit-function-declaration -pipe"
-XENO_USER_LDFLAGS=
+dnl Exported CFLAGS and LDFLAGS, shared with internal flags
+XENO_USER_APP_CFLAGS="-D_GNU_SOURCE -D_REENTRANT"
+XENO_USER_APP_LDFLAGS=
 
-dnl Exported CFLAGS and LDFLAGS, may be enhanced per-arch below
-XENO_USER_APP_CFLAGS=$XENO_USER_CFLAGS
-XENO_USER_APP_LDFLAGS=$XENO_USER_LDFLAGS
+dnl Internal CFLAGS and LDFLAGS, may be enhanced per-arch below
+XENO_USER_CFLAGS="$XENO_USER_CFLAGS -Wall -Werror-implicit-function-declaration -pipe"
+XENO_USER_LDFLAGS="$XENO_USER_APP_LDFLAGS"
 
 case $XENO_TARGET_ARCH in
  x86)
-- 
1.7.3.4

Re: [Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Gilles Chanteperdrix]

On 02/03/2012 03:50 PM, Jan Kiszka wrote:
> -Werror-implicit-function-declaration is not compatible with C++, and
> also decisions about -Wall and -pipe should be left to the application.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
> ---
>  configure.in |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.in b/configure.in
> index b2563ee..2185925 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -448,13 +448,13 @@ else
>  fi
>  AC_MSG_RESULT([done])
>  
> -dnl Common CFLAGS and LDFLAGS
> -XENO_USER_CFLAGS="-D_GNU_SOURCE -D_REENTRANT -Wall -Werror-implicit-function-declaration -pipe"
> -XENO_USER_LDFLAGS=
> +dnl Exported CFLAGS and LDFLAGS, shared with internal flags
> +XENO_USER_APP_CFLAGS="-D_GNU_SOURCE -D_REENTRANT"
> +XENO_USER_APP_LDFLAGS=
>  
> -dnl Exported CFLAGS and LDFLAGS, may be enhanced per-arch below
> -XENO_USER_APP_CFLAGS=$XENO_USER_CFLAGS
> -XENO_USER_APP_LDFLAGS=$XENO_USER_LDFLAGS
> +dnl Internal CFLAGS and LDFLAGS, may be enhanced per-arch below
> +XENO_USER_CFLAGS="$XENO_USER_CFLAGS -Wall -Werror-implicit-function-declaration -pipe"
> +XENO_USER_LDFLAGS="$XENO_USER_APP_LDFLAGS"

We do not build C++ code, so I see no problem with using flags
incompatible with C++, and customize the flags according to our
preferences. Now, the flags returned by xeno-config are another issue,
if this is what you want to change, please do not change the flags used
to compile xenomai globally.

-- 
					    Gilles.

Re: [Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Gilles Chanteperdrix]

On 02/03/2012 04:22 PM, Gilles Chanteperdrix wrote:
> On 02/03/2012 03:50 PM, Jan Kiszka wrote:
>> -Werror-implicit-function-declaration is not compatible with C++, and
>> also decisions about -Wall and -pipe should be left to the application.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>> ---
>>  configure.in |   12 ++++++------
>>  1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure.in b/configure.in
>> index b2563ee..2185925 100644
>> --- a/configure.in
>> +++ b/configure.in
>> @@ -448,13 +448,13 @@ else
>>  fi
>>  AC_MSG_RESULT([done])
>>  
>> -dnl Common CFLAGS and LDFLAGS
>> -XENO_USER_CFLAGS="-D_GNU_SOURCE -D_REENTRANT -Wall -Werror-implicit-function-declaration -pipe"
>> -XENO_USER_LDFLAGS=
>> +dnl Exported CFLAGS and LDFLAGS, shared with internal flags
>> +XENO_USER_APP_CFLAGS="-D_GNU_SOURCE -D_REENTRANT"
>> +XENO_USER_APP_LDFLAGS=
>>  
>> -dnl Exported CFLAGS and LDFLAGS, may be enhanced per-arch below
>> -XENO_USER_APP_CFLAGS=$XENO_USER_CFLAGS
>> -XENO_USER_APP_LDFLAGS=$XENO_USER_LDFLAGS
>> +dnl Internal CFLAGS and LDFLAGS, may be enhanced per-arch below
>> +XENO_USER_CFLAGS="$XENO_USER_CFLAGS -Wall -Werror-implicit-function-declaration -pipe"
>> +XENO_USER_LDFLAGS="$XENO_USER_APP_LDFLAGS"
> 
> We do not build C++ code, so I see no problem with using flags
> incompatible with C++, and customize the flags according to our
> preferences. Now, the flags returned by xeno-config are another issue,
> if this is what you want to change, please do not change the flags used
> to compile xenomai globally.
> 
Which is exactly what your patch is doing, sorry for the noise, the
patch looks fine.

-- 
					    Gilles.

Re: [Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Gilles Chanteperdrix]

On 02/03/2012 03:50 PM, Jan Kiszka wrote:
> -Werror-implicit-function-declaration is not compatible with C++, and
> also decisions about -Wall and -pipe should be left to the application.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>

Had to revert this patch, it causes a build failure when cross-compiling
(for ARM, I do not know if it matters).

-- 
                                                                Gilles.

Re: [Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Jan Kiszka]

On 2012-02-07 17:18, Gilles Chanteperdrix wrote:
> On 02/03/2012 03:50 PM, Jan Kiszka wrote:
>> -Werror-implicit-function-declaration is not compatible with C++, and
>> also decisions about -Wall and -pipe should be left to the application.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
> 
> Had to revert this patch, it causes a build failure when cross-compiling
> (for ARM, I do not know if it matters).

-pipe? Or a weird compiler bug? -Wsomething can't make a difference.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

Re: [Xenomai-core] [PATCH] Only export required CFLAGS via xeno-config

[Gilles Chanteperdrix]

On 02/07/2012 05:20 PM, Jan Kiszka wrote:
> On 2012-02-07 17:18, Gilles Chanteperdrix wrote:
>> On 02/03/2012 03:50 PM, Jan Kiszka wrote:
>>> -Werror-implicit-function-declaration is not compatible with C++, and
>>> also decisions about -Wall and -pipe should be left to the application.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>
>> Had to revert this patch, it causes a build failure when cross-compiling
>> (for ARM, I do not know if it matters).
> 
> -pipe? Or a weird compiler bug? -Wsomething can't make a difference.
> 
> Jan
> 
sighandler_t not defined, so I suspect -D_GNU_SOURCE gets lost. Anyway,
I will retry this one later, am working on other issues now.

-- 
					    Gilles.