[Qemu-devel] [PATCH 0/6] VGA patches

[Qemu-devel] [PATCH 0/6] VGA patches

[Blue Swirl]

Patch 1 has been sent several times, though the logic has been copied
from flawed implementations before.

Other patches should be trivial.

URL	git://repo.or.cz/qemu/blueswirl.git
	http://repo.or.cz/r/qemu/blueswirl.git

Blue Swirl (6):
  memory: change dirty getting API to take a size
  vga: move Cirrus VGA template to its own file
  Add vga.h unmodified from Linux
  vga.h: remove unused stuff and reformat
  vga: use constants from vga.h
  vga: improve documentation

 arch_init.c              |    7 +-
 exec-obsolete.h          |   15 ++-
 hw/cirrus_vga.c          |    9 +
 hw/cirrus_vga_template.h |  102 ++++++++++++
 hw/framebuffer.c         |    9 +-
 hw/g364fb.c              |    3 +-
 hw/sm501.c               |   11 +-
 hw/tcx.c                 |   19 +--
 hw/vga.c                 |  391 +++++++++++++++++++++++++---------------------
 hw/vga.h                 |  159 +++++++++++++++++++
 hw/vga_int.h             |   16 --
 hw/vga_template.h        |   74 +--------
 memory.c                 |    5 +-
 memory.h                 |    9 +-
 14 files changed, 526 insertions(+), 303 deletions(-)
 create mode 100644 hw/cirrus_vga_template.h
 create mode 100644 hw/vga.h

-- 
1.7.9.rc0

Re: [Qemu-devel] [PATCH 0/6] VGA patches

[Blue Swirl]

On Sun, Jan 29, 2012 at 19:12, Blue Swirl <blauwirbel@gmail.com> wrote:
> Patch 1 has been sent several times, though the logic has been copied
> from flawed implementations before.
>
> Other patches should be trivial.

Pushed. I compared vga.o object files with codiff and objdump
disassembler before and after the constant patch and the code was
identical.

> URL     git://repo.or.cz/qemu/blueswirl.git
>        http://repo.or.cz/r/qemu/blueswirl.git
>
> Blue Swirl (6):
>  memory: change dirty getting API to take a size
>  vga: move Cirrus VGA template to its own file
>  Add vga.h unmodified from Linux
>  vga.h: remove unused stuff and reformat
>  vga: use constants from vga.h
>  vga: improve documentation
>
>  arch_init.c              |    7 +-
>  exec-obsolete.h          |   15 ++-
>  hw/cirrus_vga.c          |    9 +
>  hw/cirrus_vga_template.h |  102 ++++++++++++
>  hw/framebuffer.c         |    9 +-
>  hw/g364fb.c              |    3 +-
>  hw/sm501.c               |   11 +-
>  hw/tcx.c                 |   19 +--
>  hw/vga.c                 |  391 +++++++++++++++++++++++++---------------------
>  hw/vga.h                 |  159 +++++++++++++++++++
>  hw/vga_int.h             |   16 --
>  hw/vga_template.h        |   74 +--------
>  memory.c                 |    5 +-
>  memory.h                 |    9 +-
>  14 files changed, 526 insertions(+), 303 deletions(-)
>  create mode 100644 hw/cirrus_vga_template.h
>  create mode 100644 hw/vga.h
>
> --
> 1.7.9.rc0

Re: [Qemu-devel] [PATCH 0/6] VGA patches

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On 2012-02-04 14:15, Blue Swirl wrote:
> On Sun, Jan 29, 2012 at 19:12, Blue Swirl <blauwirbel@gmail.com> wrote:
>> Patch 1 has been sent several times, though the logic has been copied
>> from flawed implementations before.
>>
>> Other patches should be trivial.
> 
> Pushed. I compared vga.o object files with codiff and objdump
> disassembler before and after the constant patch and the code was
> identical.
> 
>> URL     git://repo.or.cz/qemu/blueswirl.git
>>        http://repo.or.cz/r/qemu/blueswirl.git
>>
>> Blue Swirl (6):
>>  memory: change dirty getting API to take a size

This causes regressions of WinXP guests. The upper half of the screen is
not properly updated.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [Qemu-devel] [PATCH 0/6] VGA patches

[Blue Swirl]

On Sat, Feb 4, 2012 at 16:16, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2012-02-04 14:15, Blue Swirl wrote:
>> On Sun, Jan 29, 2012 at 19:12, Blue Swirl <blauwirbel@gmail.com> wrote:
>>> Patch 1 has been sent several times, though the logic has been copied
>>> from flawed implementations before.
>>>
>>> Other patches should be trivial.
>>
>> Pushed. I compared vga.o object files with codiff and objdump
>> disassembler before and after the constant patch and the code was
>> identical.
>>
>>> URL     git://repo.or.cz/qemu/blueswirl.git
>>>        http://repo.or.cz/r/qemu/blueswirl.git
>>>
>>> Blue Swirl (6):
>>>  memory: change dirty getting API to take a size
>
> This causes regressions of WinXP guests. The upper half of the screen is
> not properly updated.

I can't reproduce this, but can you try the following:

diff --git a/hw/vga.c b/hw/vga.c
index d87c4f9..729ab8d 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1779,7 +1779,7 @@ static void vga_draw_graphic(VGACommonState *s,
int full_update)
         }
         page0 = addr;
         page1 = addr + bwidth - 1;
-        update = memory_region_get_dirty(&s->vram, page0, page1,
+        update = memory_region_get_dirty(&s->vram, page0, bwidth - 1,
                                          DIRTY_MEMORY_VGA);
         /* explicit invalidation for the hardware cursor */
         update |= (s->invalidated_y_table[y >> 5] >> (y & 0x1f)) & 1;