From: Tabi Timur-B04825 <B04825@freescale.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tabi Timur-B04825 <B04825@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mikey@neuling.org" <mikey@neuling.org>,
"FlorianSchandinat@gmx.de" <FlorianSchandinat@gmx.de>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: fsl-diu: enable_lcdc() takes a pointer, not struct...
Date: Sun, 05 Feb 2012 15:12:18 +0000 [thread overview]
Message-ID: <4F2E9C50.3050500@freescale.com> (raw)
In-Reply-To: <20120205062835.GA23916@ZenIV.linux.org.uk>
Al Viro wrote:
> A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...
>
> Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
This is already fixed in fbdev, although I can't find the patch in the
archives (http://marc.info/?l=linux-fbdev&r=3&b 1201&w=2).
>
> diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
> index acf292b..629ae00 100644
> --- a/drivers/video/fsl-diu-fb.c
> +++ b/drivers/video/fsl-diu-fb.c
> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - disable_lcdc(data->fsl_diu_info[0]);
> + disable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - enable_lcdc(data->fsl_diu_info[0]);
> + enable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
>
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Tabi Timur-B04825 <B04825@freescale.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tabi Timur-B04825 <B04825@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mikey@neuling.org" <mikey@neuling.org>,
"FlorianSchandinat@gmx.de" <FlorianSchandinat@gmx.de>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: fsl-diu: enable_lcdc() takes a pointer, not struct...
Date: Sun, 5 Feb 2012 15:12:18 +0000 [thread overview]
Message-ID: <4F2E9C50.3050500@freescale.com> (raw)
In-Reply-To: <20120205062835.GA23916@ZenIV.linux.org.uk>
Al Viro wrote:
> A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...
>
> Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
This is already fixed in fbdev, although I can't find the patch in the
archives (http://marc.info/?l=linux-fbdev&r=3&b=201201&w=2).
>
> diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
> index acf292b..629ae00 100644
> --- a/drivers/video/fsl-diu-fb.c
> +++ b/drivers/video/fsl-diu-fb.c
> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - disable_lcdc(data->fsl_diu_info[0]);
> + disable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - enable_lcdc(data->fsl_diu_info[0]);
> + enable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-02-05 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 6:28 fsl-diu: enable_lcdc() takes a pointer, not struct Al Viro
2012-02-05 15:12 ` Tabi Timur-B04825 [this message]
2012-02-05 15:12 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2E9C50.3050500@freescale.com \
--to=b04825@freescale.com \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.