From: David Henningsson <david.henningsson@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: hda/realtek - cleanup a condition
Date: Mon, 06 Feb 2012 09:06:11 +0100 [thread overview]
Message-ID: <4F2F89F3.4060301@canonical.com> (raw)
In-Reply-To: <20120206075218.GA14304@elgon.mountain>
On 02/06/2012 08:52 AM, Dan Carpenter wrote:
> Sparse complains that "spec->multiout.dac_nids" is a pointer.
>
> sound/pci/hda/patch_realtek.c:2321:37: error: incompatible types for operation (>)
> sound/pci/hda/patch_realtek.c:2321:37: left side has type unsigned short const [usertype] *dac_nids
> sound/pci/hda/patch_realtek.c:2321:37: right side has type int
>
> I think the intent here was just to check if it was non-NULL, but please
> double check.
It could also have meant to be "if (spec->multiout.num_dacs > 0)", but
either way, it seems very unlikely that the condition is false.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
WARNING: multiple messages have this Message-ID (diff)
From: David Henningsson <david.henningsson@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [alsa-devel] [patch] ALSA: hda/realtek - cleanup a condition
Date: Mon, 06 Feb 2012 08:06:11 +0000 [thread overview]
Message-ID: <4F2F89F3.4060301@canonical.com> (raw)
In-Reply-To: <20120206075218.GA14304@elgon.mountain>
On 02/06/2012 08:52 AM, Dan Carpenter wrote:
> Sparse complains that "spec->multiout.dac_nids" is a pointer.
>
> sound/pci/hda/patch_realtek.c:2321:37: error: incompatible types for operation (>)
> sound/pci/hda/patch_realtek.c:2321:37: left side has type unsigned short const [usertype] *dac_nids
> sound/pci/hda/patch_realtek.c:2321:37: right side has type int
>
> I think the intent here was just to check if it was non-NULL, but please
> double check.
It could also have meant to be "if (spec->multiout.num_dacs > 0)", but
either way, it seems very unlikely that the condition is false.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
next prev parent reply other threads:[~2012-02-06 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 7:52 [patch] ALSA: hda/realtek - cleanup a condition Dan Carpenter
2012-02-06 7:52 ` Dan Carpenter
2012-02-06 8:06 ` David Henningsson [this message]
2012-02-06 8:06 ` [alsa-devel] " David Henningsson
2012-02-06 9:09 ` Takashi Iwai
2012-02-06 9:09 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2F89F3.4060301@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.