From: Daniel Hellstrom <daniel@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: sparc32: enabled CONFIG_SPARC_LEON leads to compile error
Date: Mon, 06 Feb 2012 14:46:21 +0000 [thread overview]
Message-ID: <4F2FE7BD.6080200@gaisler.com> (raw)
On 01/22/2012 08:57 PM, Kirill Tkhai wrote:
> Hello!
>
> I've just tried to compile kernel with enabled CONFIG_SPARC_LEON option
> and I got a compile error. This is:
>
> CC arch/sparc/kernel/leon_pci.o
> arch/sparc/kernel/leon_pci.c:156: error: redefinition of 'pci_device_to_OF_node'
> include/linux/pci.h:1623: error: previous definition of 'pci_device_to_OF_node' was here
> make[1]: *** [arch/sparc/kernel/leon_pci.o] Error 1
> make: *** [arch/sparc/kernel] Error 2
> make: *** Waiting for unfinished jobs....
>
> It seems it happened because of closeness of two commits:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;hd099d981c9916ec4a485b3ffbb89fa877fc595f
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h&893c1368aeb96e06e4f9dce61bbde3351d5e9f
>
> It looks like it's enough to remove double function from leon_pci.c.
>
> Kirill
Hello,
Sorry for my later reply. I haven't investigated this but at first look the "pci/of: Consolidate .." patch seems bad. After the patch it does not longer return the prom node for PCIC PCI device?
When it comes to the LEON code I think it is safe to remove pci_device_to_OF_node() function.
Regards,
Daniel
next reply other threads:[~2012-02-06 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 14:46 Daniel Hellstrom [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-22 19:57 sparc32: enabled CONFIG_SPARC_LEON leads to compile error Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2FE7BD.6080200@gaisler.com \
--to=daniel@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.