* Re: sparc32: enabled CONFIG_SPARC_LEON leads to compile error
@ 2012-02-06 14:46 Daniel Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Hellstrom @ 2012-02-06 14:46 UTC (permalink / raw)
To: sparclinux
On 01/22/2012 08:57 PM, Kirill Tkhai wrote:
> Hello!
>
> I've just tried to compile kernel with enabled CONFIG_SPARC_LEON option
> and I got a compile error. This is:
>
> CC arch/sparc/kernel/leon_pci.o
> arch/sparc/kernel/leon_pci.c:156: error: redefinition of 'pci_device_to_OF_node'
> include/linux/pci.h:1623: error: previous definition of 'pci_device_to_OF_node' was here
> make[1]: *** [arch/sparc/kernel/leon_pci.o] Error 1
> make: *** [arch/sparc/kernel] Error 2
> make: *** Waiting for unfinished jobs....
>
> It seems it happened because of closeness of two commits:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;hd099d981c9916ec4a485b3ffbb89fa877fc595f
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h&893c1368aeb96e06e4f9dce61bbde3351d5e9f
>
> It looks like it's enough to remove double function from leon_pci.c.
>
> Kirill
Hello,
Sorry for my later reply. I haven't investigated this but at first look the "pci/of: Consolidate .." patch seems bad. After the patch it does not longer return the prom node for PCIC PCI device?
When it comes to the LEON code I think it is safe to remove pci_device_to_OF_node() function.
Regards,
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
* sparc32: enabled CONFIG_SPARC_LEON leads to compile error
@ 2012-01-22 19:57 Kirill Tkhai
0 siblings, 0 replies; 2+ messages in thread
From: Kirill Tkhai @ 2012-01-22 19:57 UTC (permalink / raw)
To: sparclinux
Hello!
I've just tried to compile kernel with enabled CONFIG_SPARC_LEON option
and I got a compile error. This is:
CC arch/sparc/kernel/leon_pci.o
arch/sparc/kernel/leon_pci.c:156: error: redefinition of 'pci_device_to_OF_node'
include/linux/pci.h:1623: error: previous definition of 'pci_device_to_OF_node' was here
make[1]: *** [arch/sparc/kernel/leon_pci.o] Error 1
make: *** [arch/sparc/kernel] Error 2
make: *** Waiting for unfinished jobs....
It seems it happened because of closeness of two commits:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;hd099d981c9916ec4a485b3ffbb89fa877fc595f
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h&893c1368aeb96e06e4f9dce61bbde3351d5e9f
It looks like it's enough to remove double function from leon_pci.c.
Kirill
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-06 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-06 14:46 sparc32: enabled CONFIG_SPARC_LEON leads to compile error Daniel Hellstrom
-- strict thread matches above, loose matches on Subject: below --
2012-01-22 19:57 Kirill Tkhai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.