From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Christoffer Dall <c.dall@virtualopensystems.com>,
kvm@vger.kernel.org, Marc.Zyngier@arm.com, agraf@suse.de,
kvm-ppc@vger.kernel.org, avi@redhat.com,
tech@virtualopensystems.com
Subject: Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code
Date: Mon, 06 Feb 2012 20:06:04 +0000 [thread overview]
Message-ID: <4F3032AC.10809@web.de> (raw)
In-Reply-To: <20120206182504.GC19821@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On 2012-02-06 19:25, Marcelo Tosatti wrote:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index c38efd7..a1761ff 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>> kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
>> if (vcpu->cpu != cpu)
>> kvm_migrate_timers(vcpu);
>> - vcpu->cpu = cpu;
>> }
>
> This is wrong, kvm_sched_in fails to see vcpu->cpu properly. Please
> keep vcpu->cpu assignment in arch code.
True, but then kvm_sched_in is a better place for this assignment (as
it's central), no?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Christoffer Dall <c.dall@virtualopensystems.com>,
kvm@vger.kernel.org, Marc.Zyngier@arm.com, agraf@suse.de,
kvm-ppc@vger.kernel.org, avi@redhat.com,
tech@virtualopensystems.com
Subject: Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code
Date: Mon, 06 Feb 2012 21:06:04 +0100 [thread overview]
Message-ID: <4F3032AC.10809@web.de> (raw)
In-Reply-To: <20120206182504.GC19821@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On 2012-02-06 19:25, Marcelo Tosatti wrote:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index c38efd7..a1761ff 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>> kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
>> if (vcpu->cpu != cpu)
>> kvm_migrate_timers(vcpu);
>> - vcpu->cpu = cpu;
>> }
>
> This is wrong, kvm_sched_in fails to see vcpu->cpu properly. Please
> keep vcpu->cpu assignment in arch code.
True, but then kvm_sched_in is a better place for this assignment (as
it's central), no?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-02-06 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 4:27 [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code Christoffer Dall
2012-01-25 4:27 ` Christoffer Dall
2012-02-06 18:25 ` Marcelo Tosatti
2012-02-06 18:25 ` Marcelo Tosatti
2012-02-06 20:06 ` Jan Kiszka [this message]
2012-02-06 20:06 ` Jan Kiszka
2012-02-06 20:22 ` Marcelo Tosatti
2012-02-06 20:22 ` Marcelo Tosatti
2012-02-08 16:52 ` Alexander Graf
2012-02-08 16:52 ` Alexander Graf
2012-02-08 20:30 ` Christoffer Dall
2012-02-08 20:30 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3032AC.10809@web.de \
--to=jan.kiszka@web.de \
--cc=Marc.Zyngier@arm.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=c.dall@virtualopensystems.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.