From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH BUGFIX] mm: fix find_get_page() for shmem exceptional entries
Date: Tue, 07 Feb 2012 14:43:10 +0400 [thread overview]
Message-ID: <4F31003E.2090901@openvz.org> (raw)
In-Reply-To: <20120207103121.28345.28611.stgit@zurg>
Bug was added in commit v3.0-7291-g8079b1c (mm: clarify the radix_tree exceptional cases)
So, v3.1 and v3.2 affected.
Konstantin Khlebnikov wrote:
> It should return NULL, otherwise the caller will be very surprised.
>
> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org>
> ---
> mm/filemap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 518223b..ca98cb5 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -693,6 +693,7 @@ repeat:
> * here as an exceptional entry: so return it without
> * attempting to raise page count.
> */
> + page = NULL;
> goto out;
> }
> if (!page_cache_get_speculative(page))
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH BUGFIX] mm: fix find_get_page() for shmem exceptional entries
Date: Tue, 07 Feb 2012 14:43:10 +0400 [thread overview]
Message-ID: <4F31003E.2090901@openvz.org> (raw)
In-Reply-To: <20120207103121.28345.28611.stgit@zurg>
Bug was added in commit v3.0-7291-g8079b1c (mm: clarify the radix_tree exceptional cases)
So, v3.1 and v3.2 affected.
Konstantin Khlebnikov wrote:
> It should return NULL, otherwise the caller will be very surprised.
>
> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org>
> ---
> mm/filemap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 518223b..ca98cb5 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -693,6 +693,7 @@ repeat:
> * here as an exceptional entry: so return it without
> * attempting to raise page count.
> */
> + page = NULL;
> goto out;
> }
> if (!page_cache_get_speculative(page))
>
next prev parent reply other threads:[~2012-02-07 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 10:31 [PATCH BUGFIX] mm: fix find_get_page() for shmem exceptional entries Konstantin Khlebnikov
2012-02-07 10:31 ` Konstantin Khlebnikov
2012-02-07 10:43 ` Konstantin Khlebnikov [this message]
2012-02-07 10:43 ` Konstantin Khlebnikov
2012-02-07 18:31 ` Hugh Dickins
2012-02-07 18:31 ` Hugh Dickins
2012-02-08 1:41 ` Konstantin Khlebnikov
2012-02-08 1:41 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F31003E.2090901@openvz.org \
--to=khlebnikov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.