* Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id [not found] <1328367090-10402-1-git-send-email-rnayak@ti.com> @ 2012-02-07 10:02 ` S, Venkatraman [not found] ` <1328367090-10402-7-git-send-email-rnayak@ti.com> 1 sibling, 0 replies; 10+ messages in thread From: S, Venkatraman @ 2012-02-07 10:02 UTC (permalink / raw) To: Rajendra Nayak Cc: linux-mmc, cjb, linux-omap, balajitk, linux-arm-kernel, linaro-dev, patches On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak@ti.com> wrote: > This series mainly cleans up all instances of hardcoding's in > the driver based on pdev->id. This is cleanup leading to the > DT adaptation of omap_hsmmc driver. > > Patches are based on 3.3-rc2 and can be found here > git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup > > Tested the patches on my omap4 boards (panda and SDP) but > haven't tested yet on omap3/2 since I did'nt have boards > handy. So any testing on any omap3/2 boards is really > appreciated. I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem on the SD card, and checked again on 4430SDP. Tested-by: Venkatraman S <svenkatr@ti.com> > > regards, > Rajendra > > Balaji T K (3): > mmc: omap_hsmmc: use platform_get_resource_byname for tx/rx DMA > channels > mmc: omap_hsmmc: remove unused .set_sleep function > mmc: omap_hsmmc: Use OMAP_HSMMC_SUPPORTS_DUAL_VOLT flag to remove > host->id based hardcoding > > Rajendra Nayak (3): > mmc: omap_hsmmc: Get rid of omap_hsmmc_1_set_power function > mmc: omap_hsmmc: Get rid of omap_hsmmc_4_set_power function > mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply > > arch/arm/plat-omap/include/plat/mmc.h | 2 - > drivers/mmc/host/omap_hsmmc.c | 158 +++------------------------------ > 2 files changed, 14 insertions(+), 146 deletions(-) > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id @ 2012-02-07 10:02 ` S, Venkatraman 0 siblings, 0 replies; 10+ messages in thread From: S, Venkatraman @ 2012-02-07 10:02 UTC (permalink / raw) To: linux-arm-kernel On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak@ti.com> wrote: > This series mainly cleans up all instances of hardcoding's in > the driver based on pdev->id. This is cleanup leading to the > DT adaptation of omap_hsmmc driver. > > Patches are based on 3.3-rc2 and can be found here > git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup > > Tested the patches on my omap4 boards (panda and SDP) but > haven't tested yet on omap3/2 since I did'nt have boards > handy. So any testing on any omap3/2 boards is really > appreciated. I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem on the SD card, and checked again on 4430SDP. Tested-by: Venkatraman S <svenkatr@ti.com> > > regards, > Rajendra > > Balaji T K (3): > ?mmc: omap_hsmmc: use platform_get_resource_byname for tx/rx DMA > ? ?channels > ?mmc: omap_hsmmc: remove unused .set_sleep function > ?mmc: omap_hsmmc: Use OMAP_HSMMC_SUPPORTS_DUAL_VOLT flag to remove > ? ?host->id based hardcoding > > Rajendra Nayak (3): > ?mmc: omap_hsmmc: Get rid of omap_hsmmc_1_set_power function > ?mmc: omap_hsmmc: Get rid of omap_hsmmc_4_set_power function > ?mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply > > ?arch/arm/plat-omap/include/plat/mmc.h | ? ?2 - > ?drivers/mmc/host/omap_hsmmc.c ? ? ? ? | ?158 +++------------------------------ > ?2 files changed, 14 insertions(+), 146 deletions(-) > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id 2012-02-07 10:02 ` S, Venkatraman @ 2012-02-07 15:49 ` Rajendra Nayak -1 siblings, 0 replies; 10+ messages in thread From: Rajendra Nayak @ 2012-02-07 15:49 UTC (permalink / raw) To: S, Venkatraman Cc: cjb, linaro-dev, balajitk, patches, linux-mmc, linux-omap, linux-arm-kernel On Tuesday 07 February 2012 02:02 AM, S, Venkatraman wrote: > I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem > on the SD card, and checked again on 4430SDP. > > Tested-by: Venkatraman S<svenkatr@ti.com> Great, thanks Venkat. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id @ 2012-02-07 15:49 ` Rajendra Nayak 0 siblings, 0 replies; 10+ messages in thread From: Rajendra Nayak @ 2012-02-07 15:49 UTC (permalink / raw) To: linux-arm-kernel On Tuesday 07 February 2012 02:02 AM, S, Venkatraman wrote: > I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem > on the SD card, and checked again on 4430SDP. > > Tested-by: Venkatraman S<svenkatr@ti.com> Great, thanks Venkat. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id 2012-02-07 10:02 ` S, Venkatraman @ 2012-02-10 13:27 ` T Krishnamoorthy, Balaji -1 siblings, 0 replies; 10+ messages in thread From: T Krishnamoorthy, Balaji @ 2012-02-10 13:27 UTC (permalink / raw) To: S, Venkatraman, Rajendra Nayak, linux-mmc, cjb, linux-omap, linux-arm-kernel, linaro-dev, patches On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman <svenkatr@ti.com> wrote: > On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak@ti.com> wrote: >> This series mainly cleans up all instances of hardcoding's in >> the driver based on pdev->id. This is cleanup leading to the >> DT adaptation of omap_hsmmc driver. >> >> Patches are based on 3.3-rc2 and can be found here >> git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup >> >> Tested the patches on my omap4 boards (panda and SDP) but >> haven't tested yet on omap3/2 since I did'nt have boards >> handy. So any testing on any omap3/2 boards is really >> appreciated. Tested this series on 2430SDP with FS on SD card > > I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem > on the SD card, and checked again on 4430SDP. > > Tested-by: Venkatraman S <svenkatr@ti.com> > >> >> regards, >> Rajendra >> >> Balaji T K (3): >> mmc: omap_hsmmc: use platform_get_resource_byname for tx/rx DMA >> channels >> mmc: omap_hsmmc: remove unused .set_sleep function >> mmc: omap_hsmmc: Use OMAP_HSMMC_SUPPORTS_DUAL_VOLT flag to remove >> host->id based hardcoding >> >> Rajendra Nayak (3): >> mmc: omap_hsmmc: Get rid of omap_hsmmc_1_set_power function >> mmc: omap_hsmmc: Get rid of omap_hsmmc_4_set_power function >> mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply >> >> arch/arm/plat-omap/include/plat/mmc.h | 2 - >> drivers/mmc/host/omap_hsmmc.c | 158 +++------------------------------ >> 2 files changed, 14 insertions(+), 146 deletions(-) >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id @ 2012-02-10 13:27 ` T Krishnamoorthy, Balaji 0 siblings, 0 replies; 10+ messages in thread From: T Krishnamoorthy, Balaji @ 2012-02-10 13:27 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman <svenkatr@ti.com> wrote: > On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak@ti.com> wrote: >> This series mainly cleans up all instances of hardcoding's in >> the driver based on pdev->id. This is cleanup leading to the >> DT adaptation of omap_hsmmc driver. >> >> Patches are based on 3.3-rc2 and can be found here >> git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup >> >> Tested the patches on my omap4 boards (panda and SDP) but >> haven't tested yet on omap3/2 since I did'nt have boards >> handy. So any testing on any omap3/2 boards is really >> appreciated. Tested this series on 2430SDP with FS on SD card > > I gave it a spin on Beagleboard-XM (OMAP3630) with root filesystem > on the SD card, and checked again on 4430SDP. > > Tested-by: Venkatraman S <svenkatr@ti.com> > >> >> regards, >> Rajendra >> >> Balaji T K (3): >> ?mmc: omap_hsmmc: use platform_get_resource_byname for tx/rx DMA >> ? ?channels >> ?mmc: omap_hsmmc: remove unused .set_sleep function >> ?mmc: omap_hsmmc: Use OMAP_HSMMC_SUPPORTS_DUAL_VOLT flag to remove >> ? ?host->id based hardcoding >> >> Rajendra Nayak (3): >> ?mmc: omap_hsmmc: Get rid of omap_hsmmc_1_set_power function >> ?mmc: omap_hsmmc: Get rid of omap_hsmmc_4_set_power function >> ?mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply >> >> ?arch/arm/plat-omap/include/plat/mmc.h | ? ?2 - >> ?drivers/mmc/host/omap_hsmmc.c ? ? ? ? | ?158 +++------------------------------ >> ?2 files changed, 14 insertions(+), 146 deletions(-) >> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id 2012-02-10 13:27 ` T Krishnamoorthy, Balaji @ 2012-02-14 5:18 ` Rajendra Nayak -1 siblings, 0 replies; 10+ messages in thread From: Rajendra Nayak @ 2012-02-14 5:18 UTC (permalink / raw) To: T Krishnamoorthy, Balaji Cc: S, Venkatraman, linux-mmc, cjb, linux-omap, linux-arm-kernel, linaro-dev, patches On Friday 10 February 2012 06:57 PM, T Krishnamoorthy, Balaji wrote: > On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman<svenkatr@ti.com> wrote: >> > On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak<rnayak@ti.com> wrote: >>> >> This series mainly cleans up all instances of hardcoding's in >>> >> the driver based on pdev->id. This is cleanup leading to the >>> >> DT adaptation of omap_hsmmc driver. >>> >> >>> >> Patches are based on 3.3-rc2 and can be found here >>> >> git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup >>> >> >>> >> Tested the patches on my omap4 boards (panda and SDP) but >>> >> haven't tested yet on omap3/2 since I did'nt have boards >>> >> handy. So any testing on any omap3/2 boards is really >>> >> appreciated. > Tested this series on 2430SDP with FS on SD card > Thanks, will repost adding Tested-by from you and Venkat, also getting rid of the one instance of host->id usage left in a debug print. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id @ 2012-02-14 5:18 ` Rajendra Nayak 0 siblings, 0 replies; 10+ messages in thread From: Rajendra Nayak @ 2012-02-14 5:18 UTC (permalink / raw) To: linux-arm-kernel On Friday 10 February 2012 06:57 PM, T Krishnamoorthy, Balaji wrote: > On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman<svenkatr@ti.com> wrote: >> > On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak<rnayak@ti.com> wrote: >>> >> This series mainly cleans up all instances of hardcoding's in >>> >> the driver based on pdev->id. This is cleanup leading to the >>> >> DT adaptation of omap_hsmmc driver. >>> >> >>> >> Patches are based on 3.3-rc2 and can be found here >>> >> git://gitorious.org/omap-pm/linux.git omap_hsmmc_cleanup >>> >> >>> >> Tested the patches on my omap4 boards (panda and SDP) but >>> >> haven't tested yet on omap3/2 since I did'nt have boards >>> >> handy. So any testing on any omap3/2 boards is really >>> >> appreciated. > Tested this series on 2430SDP with FS on SD card > Thanks, will repost adding Tested-by from you and Venkat, also getting rid of the one instance of host->id usage left in a debug print. ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1328367090-10402-7-git-send-email-rnayak@ti.com>]
[parent not found: <1328367090-10402-7-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply [not found] ` <1328367090-10402-7-git-send-email-rnayak@ti.com> @ 2012-02-07 18:34 ` S, Venkatraman 0 siblings, 0 replies; 10+ messages in thread From: S, Venkatraman @ 2012-02-07 18:34 UTC (permalink / raw) To: Rajendra Nayak Cc: linaro-dev-cunTk1MwBs8s++Sfvej+rw, balajitk-l0cyMroinI0, patches-QSEj5FYQhm4dnm+yROfE0A, linux-mmc-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org> wrote: > MMC1 is not the only instance that can be used/wired for SD. > So remove this assumption from the driver. > > Signed-off-by: Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org> > --- > drivers/mmc/host/omap_hsmmc.c | 14 -------------- > 1 files changed, 0 insertions(+), 14 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 17e264b..97d3065 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -300,7 +300,6 @@ static int omap_hsmmc_set_power(struct device *dev, int slot, int power_on, > static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > { > struct regulator *reg; > - int ret = 0; > int ocr_value = 0; > > mmc_slot(host).set_power = omap_hsmmc_set_power; > @@ -308,15 +307,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > reg = regulator_get(host->dev, "vmmc"); > if (IS_ERR(reg)) { > dev_dbg(host->dev, "vmmc regulator missing\n"); > - /* > - * HACK: until fixed.c regulator is usable, > - * we don't require a main regulator > - * for MMC2 or MMC3 > - */ > - if (host->id == OMAP_MMC1_DEVID) { > - ret = PTR_ERR(reg); > - goto err; > - } > } else { > host->vcc = reg; > ocr_value = mmc_regulator_get_ocrmask(reg); > @@ -358,10 +348,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > } > > return 0; > - > -err: > - mmc_slot(host).set_power = NULL; > - return ret; > } > > static void omap_hsmmc_reg_put(struct omap_hsmmc_host *host) > -- Almost all usage of the id field is gone, except for a trivial debug print. Would be prudent to get rid of it entirely from struct omap_hsmmc_host. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply @ 2012-02-07 18:34 ` S, Venkatraman 0 siblings, 0 replies; 10+ messages in thread From: S, Venkatraman @ 2012-02-07 18:34 UTC (permalink / raw) To: linux-arm-kernel On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak@ti.com> wrote: > MMC1 is not the only instance that can be used/wired for SD. > So remove this assumption from the driver. > > Signed-off-by: Rajendra Nayak <rnayak@ti.com> > --- > ?drivers/mmc/host/omap_hsmmc.c | ? 14 -------------- > ?1 files changed, 0 insertions(+), 14 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 17e264b..97d3065 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -300,7 +300,6 @@ static int omap_hsmmc_set_power(struct device *dev, int slot, int power_on, > ?static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > ?{ > ? ? ? ?struct regulator *reg; > - ? ? ? int ret = 0; > ? ? ? ?int ocr_value = 0; > > ? ? ? ?mmc_slot(host).set_power = omap_hsmmc_set_power; > @@ -308,15 +307,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > ? ? ? ?reg = regulator_get(host->dev, "vmmc"); > ? ? ? ?if (IS_ERR(reg)) { > ? ? ? ? ? ? ? ?dev_dbg(host->dev, "vmmc regulator missing\n"); > - ? ? ? ? ? ? ? /* > - ? ? ? ? ? ? ? * HACK: until fixed.c regulator is usable, > - ? ? ? ? ? ? ? * we don't require a main regulator > - ? ? ? ? ? ? ? * for MMC2 or MMC3 > - ? ? ? ? ? ? ? */ > - ? ? ? ? ? ? ? if (host->id == OMAP_MMC1_DEVID) { > - ? ? ? ? ? ? ? ? ? ? ? ret = PTR_ERR(reg); > - ? ? ? ? ? ? ? ? ? ? ? goto err; > - ? ? ? ? ? ? ? } > ? ? ? ?} else { > ? ? ? ? ? ? ? ?host->vcc = reg; > ? ? ? ? ? ? ? ?ocr_value = mmc_regulator_get_ocrmask(reg); > @@ -358,10 +348,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > ? ? ? ?} > > ? ? ? ?return 0; > - > -err: > - ? ? ? mmc_slot(host).set_power = NULL; > - ? ? ? return ret; > ?} > > ?static void omap_hsmmc_reg_put(struct omap_hsmmc_host *host) > -- Almost all usage of the id field is gone, except for a trivial debug print. Would be prudent to get rid of it entirely from struct omap_hsmmc_host. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-02-14 5:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1328367090-10402-1-git-send-email-rnayak@ti.com>
2012-02-07 10:02 ` [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id S, Venkatraman
2012-02-07 10:02 ` S, Venkatraman
2012-02-07 15:49 ` Rajendra Nayak
2012-02-07 15:49 ` Rajendra Nayak
2012-02-10 13:27 ` T Krishnamoorthy, Balaji
2012-02-10 13:27 ` T Krishnamoorthy, Balaji
2012-02-14 5:18 ` Rajendra Nayak
2012-02-14 5:18 ` Rajendra Nayak
[not found] ` <1328367090-10402-7-git-send-email-rnayak@ti.com>
[not found] ` <1328367090-10402-7-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2012-02-07 18:34 ` [PATCH 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply S, Venkatraman
2012-02-07 18:34 ` S, Venkatraman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.