From: Evgeny Voevodin <e.voevodin@samsung.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com,
Dmitry Solodkiy <d.solodkiy@samsung.com>
Subject: [Qemu-devel] Broken realview
Date: Thu, 09 Feb 2012 09:16:42 +0400 [thread overview]
Message-ID: <4F3356BA.9080000@samsung.com> (raw)
Since last QOM patch set landed into master, realview-pbx-a9,
realview-eb-mpcore (suppose that other too) abort with error:
qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp'
failed.
Aborted
Bisect result:
9b170e60adc6dc01564128cf09f96ec923ed6526 is the first bad commit
commit 9b170e60adc6dc01564128cf09f96ec923ed6526
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu Feb 2 12:51:44 2012 +0100
qdev: access properties via QOM
Do not poke anymore in the struct when accessing qdev properties.
Instead, ask the object to set the right value.
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
next reply other threads:[~2012-02-09 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 5:16 Evgeny Voevodin [this message]
2012-02-09 6:04 ` [Qemu-devel] Broken realview Peter Maydell
2012-02-09 6:13 ` Evgeny Voevodin
2012-02-09 6:15 ` Peter Maydell
2012-02-09 6:18 ` Evgeny Voevodin
2012-02-09 7:08 ` Evgeny Voevodin
2012-02-09 6:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3356BA.9080000@samsung.com \
--to=e.voevodin@samsung.com \
--cc=aliguori@us.ibm.com \
--cc=d.solodkiy@samsung.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.