Re: grub 1.99 add own module / dep problem

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

On 09.02.2012 10:47, Robert Schumann wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Heyho guys!
>
> I'm sorry if I didn't RTFM somewhere but I just couldn't find _any_
> information on how to correctly add/patch own modules into the grub
> 1.99. The problem:
>
> 1. mymod.c depends on a function in biosdisk.c
Avoid this as much as possible. Biosdisk is arch-specific, use generic 
disk functions.
> 2. mymod.c includes the biosdisk.h header correctly I suppose
> 3. I patched grub-core/Makefile.core.def with
>
> module = {
>    name = mymod;
>    common = mymod/mymod.c;
>    enable = biosdisk;
enable=i386_pc; not biosdisk
> };
>
> 4. I patched grub-core/Makefile.core.am with basically a copy from the
> hello.c module stuff (although I should probably take the arch
> dependend definitions from biosdisk mod? but I'm building i386 so it
> should work any way?)
Don't touch this file. Just rerun ./autogen.sh
>
> 5. ./configure&&  make works as expected for another module which
> doesn't include a foreign function.
>
> 6. For mymod.c I receive
> mymod/mymod.c:68: error: implicit declaration of function
> 'grub_biosdisk_get_diskinfo_standard'
This function is static ("private"). Moreover it's for very old C/H/S 
addressing.
Looks like you're going the wrong way. Can you detail what's your end goal?
> which is of course in biosdisk.c. Now my question: How do I solve this
> mystery on a code/patch base? ;) I know that I can add the biosdisk.c
> to the common code functions, but that shouldn't be necessary, huh? I
> thought that enable = biosdisk would do the trick with linked
> functions, but well... maybe you could shed some light on it.
Dependencies are tracked automatically.
>
> Cheers
> Robert
>
> - -- 
>
> |-------------------------------------------------address-+
> | work:  jacob-und-wilhelm-grimm-zentrum
> |        geschwister-scholl-str. 1, 10117 berlin
> | mail:  humboldt-universität zu berlin
> |        computer- und medienservice
> |        unter den linden 6, 10099 berlin
> |-------------------------------------------------contact-+
> | mail:  schumann@informatik.hu-berlin.de
> | icq:   93163687  |  xmpp:  betulichergutmensch@gmail.com
> | fb: 	 fb.com/rschumann  |  phone:  +49(0)30-2093-70133
> |-------------------------------------------------gpg/pgp-+
> | key:   remembrance.de/gpg/0xA5A5FAA2.asc
> | fprnt: 9220-9732-7390-7A0C-5623-3336-4233-FDF8-A5A5-FAA2
> |---------------------------------------------------------+
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk8zljkACgkQQjP9+KWl+qLypgCfb6Hbwo8YwvjTbGg7h9BVKZJd
> QNQAoLSsg7RhpsZ/ovACGkuO42JpZozI
> =oLeZ
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko