* [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
@ 2012-02-09 19:01 ` Cousson, Benoit
0 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-02-09 19:01 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kristo, Tero
If CONFIG_OF is not defined, the following error will happen.
arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function)
This is due to some hidden headers path from linux/of.h to plat/irqs.h
already reported by Russell for prm4xxx.c.
Add the #include <plat/irqs.h> in prm2xxx_3xxx.c to avoid depending
of that hidden dependency that should probably not exist in theory.
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
---
arch/arm/mach-omap2/prm2xxx_3xxx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
index c1c4d86..09e2916 100644
--- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
@@ -18,6 +18,7 @@
#include "common.h"
#include <plat/cpu.h>
+#include <plat/irqs.h>
#include <plat/prcm.h>
#include "vp.h"
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
@ 2012-02-09 19:01 ` Cousson, Benoit
0 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-02-09 19:01 UTC (permalink / raw)
To: linux-arm-kernel
If CONFIG_OF is not defined, the following error will happen.
arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
?INT_34XX_PRCM_MPU_IRQ? undeclared here (not in a function)
This is due to some hidden headers path from linux/of.h to plat/irqs.h
already reported by Russell for prm4xxx.c.
Add the #include <plat/irqs.h> in prm2xxx_3xxx.c to avoid depending
of that hidden dependency that should probably not exist in theory.
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
---
arch/arm/mach-omap2/prm2xxx_3xxx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
index c1c4d86..09e2916 100644
--- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
@@ -18,6 +18,7 @@
#include "common.h"
#include <plat/cpu.h>
+#include <plat/irqs.h>
#include <plat/prcm.h>
#include "vp.h"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
2012-02-09 19:01 ` Cousson, Benoit
@ 2012-02-09 19:15 ` Russell King - ARM Linux
-1 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2012-02-09 19:15 UTC (permalink / raw)
To: Cousson, Benoit
Cc: Tony Lindgren, Kristo, Tero, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote:
> If CONFIG_OF is not defined, the following error will happen.
>
> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
> ‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function)
>
> This is due to some hidden headers path from linux/of.h to plat/irqs.h
> already reported by Russell for prm4xxx.c.
I have the following commit from mainline. I suspect you have an old
tree.
Note: for the next merge window, I'm removing the asm/irq.h include from
asm/prom.h so that this kind of thing doesn't happen in the future.
commit d19e8f2e44a34b2a461f67ce9d0cb5bd43197c1e
Author: Paul Walmsley <paul@pwsan.com>
Date: Wed Jan 25 12:57:49 2012 -0700
ARM: OMAP2/3: PRM: fix missing plat/irqs.h build breakage
Commit 22f51371f8c35869ed850f46aa76b6cc2b502110 ("ARM: OMAP3: pm: use
prcm chain handler") breaks the build on a 2420-only config, due to
a missing include for plat/irqs.h:
CC arch/arm/mach-omap2/prm2xxx_3xxx.o
arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: 'INT_34XX_PRCM_MPU_IRQ' undeclared here (not in a function)
Fix by explicitly including it.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
index c1c4d86..9ce7654 100644
--- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
@@ -19,6 +19,7 @@
#include "common.h"
#include <plat/cpu.h>
#include <plat/prcm.h>
+#include <plat/irqs.h>
#include "vp.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
@ 2012-02-09 19:15 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2012-02-09 19:15 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote:
> If CONFIG_OF is not defined, the following error will happen.
>
> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
> ?INT_34XX_PRCM_MPU_IRQ? undeclared here (not in a function)
>
> This is due to some hidden headers path from linux/of.h to plat/irqs.h
> already reported by Russell for prm4xxx.c.
I have the following commit from mainline. I suspect you have an old
tree.
Note: for the next merge window, I'm removing the asm/irq.h include from
asm/prom.h so that this kind of thing doesn't happen in the future.
commit d19e8f2e44a34b2a461f67ce9d0cb5bd43197c1e
Author: Paul Walmsley <paul@pwsan.com>
Date: Wed Jan 25 12:57:49 2012 -0700
ARM: OMAP2/3: PRM: fix missing plat/irqs.h build breakage
Commit 22f51371f8c35869ed850f46aa76b6cc2b502110 ("ARM: OMAP3: pm: use
prcm chain handler") breaks the build on a 2420-only config, due to
a missing include for plat/irqs.h:
CC arch/arm/mach-omap2/prm2xxx_3xxx.o
arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: 'INT_34XX_PRCM_MPU_IRQ' undeclared here (not in a function)
Fix by explicitly including it.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
index c1c4d86..9ce7654 100644
--- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
@@ -19,6 +19,7 @@
#include "common.h"
#include <plat/cpu.h>
#include <plat/prcm.h>
+#include <plat/irqs.h>
#include "vp.h"
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
2012-02-09 19:15 ` Russell King - ARM Linux
@ 2012-02-09 20:05 ` Cousson, Benoit
-1 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-02-09 20:05 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Tony Lindgren, Kristo, Tero, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On 2/9/2012 8:15 PM, Russell King - ARM Linux wrote:
> On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote:
>> If CONFIG_OF is not defined, the following error will happen.
>>
>> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
>> ‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function)
>>
>> This is due to some hidden headers path from linux/of.h to plat/irqs.h
>> already reported by Russell for prm4xxx.c.
>
> I have the following commit from mainline. I suspect you have an old
> tree.
OK, it was part of the fixes Tony sent for for v3.3-rc2 but that are
were not in mainline until now.
I've just pulled -rc3 and this is indeed there.
Thanks,
Benoit
>
> Note: for the next merge window, I'm removing the asm/irq.h include from
> asm/prom.h so that this kind of thing doesn't happen in the future.
>
> commit d19e8f2e44a34b2a461f67ce9d0cb5bd43197c1e
> Author: Paul Walmsley<paul@pwsan.com>
> Date: Wed Jan 25 12:57:49 2012 -0700
>
> ARM: OMAP2/3: PRM: fix missing plat/irqs.h build breakage
>
> Commit 22f51371f8c35869ed850f46aa76b6cc2b502110 ("ARM: OMAP3: pm: use
> prcm chain handler") breaks the build on a 2420-only config, due to
> a missing include for plat/irqs.h:
>
> CC arch/arm/mach-omap2/prm2xxx_3xxx.o
> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: 'INT_34XX_PRCM_MPU_IRQ' undeclared here (not in a function)
>
> Fix by explicitly including it.
>
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> Cc: Tero Kristo<t-kristo@ti.com>
> Cc: Kevin Hilman<khilman@ti.com>
>
> diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
> index c1c4d86..9ce7654 100644
> --- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
> +++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
> @@ -19,6 +19,7 @@
> #include "common.h"
> #include<plat/cpu.h>
> #include<plat/prcm.h>
> +#include<plat/irqs.h>
>
> #include "vp.h"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error
@ 2012-02-09 20:05 ` Cousson, Benoit
0 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-02-09 20:05 UTC (permalink / raw)
To: linux-arm-kernel
On 2/9/2012 8:15 PM, Russell King - ARM Linux wrote:
> On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote:
>> If CONFIG_OF is not defined, the following error will happen.
>>
>> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error:
>> ?INT_34XX_PRCM_MPU_IRQ? undeclared here (not in a function)
>>
>> This is due to some hidden headers path from linux/of.h to plat/irqs.h
>> already reported by Russell for prm4xxx.c.
>
> I have the following commit from mainline. I suspect you have an old
> tree.
OK, it was part of the fixes Tony sent for for v3.3-rc2 but that are
were not in mainline until now.
I've just pulled -rc3 and this is indeed there.
Thanks,
Benoit
>
> Note: for the next merge window, I'm removing the asm/irq.h include from
> asm/prom.h so that this kind of thing doesn't happen in the future.
>
> commit d19e8f2e44a34b2a461f67ce9d0cb5bd43197c1e
> Author: Paul Walmsley<paul@pwsan.com>
> Date: Wed Jan 25 12:57:49 2012 -0700
>
> ARM: OMAP2/3: PRM: fix missing plat/irqs.h build breakage
>
> Commit 22f51371f8c35869ed850f46aa76b6cc2b502110 ("ARM: OMAP3: pm: use
> prcm chain handler") breaks the build on a 2420-only config, due to
> a missing include for plat/irqs.h:
>
> CC arch/arm/mach-omap2/prm2xxx_3xxx.o
> arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: 'INT_34XX_PRCM_MPU_IRQ' undeclared here (not in a function)
>
> Fix by explicitly including it.
>
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> Cc: Tero Kristo<t-kristo@ti.com>
> Cc: Kevin Hilman<khilman@ti.com>
>
> diff --git a/arch/arm/mach-omap2/prm2xxx_3xxx.c b/arch/arm/mach-omap2/prm2xxx_3xxx.c
> index c1c4d86..9ce7654 100644
> --- a/arch/arm/mach-omap2/prm2xxx_3xxx.c
> +++ b/arch/arm/mach-omap2/prm2xxx_3xxx.c
> @@ -19,6 +19,7 @@
> #include "common.h"
> #include<plat/cpu.h>
> #include<plat/prcm.h>
> +#include<plat/irqs.h>
>
> #include "vp.h"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-09 20:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 19:01 [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error Cousson, Benoit
2012-02-09 19:01 ` Cousson, Benoit
2012-02-09 19:15 ` Russell King - ARM Linux
2012-02-09 19:15 ` Russell King - ARM Linux
2012-02-09 20:05 ` Cousson, Benoit
2012-02-09 20:05 ` Cousson, Benoit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.