* [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock @ 2012-01-19 10:16 Jingoo Han 2012-01-20 0:53 ` Kyungmin Park 0 siblings, 1 reply; 6+ messages in thread From: Jingoo Han @ 2012-01-19 10:16 UTC (permalink / raw) To: 'Kukjin Kim', linux-samsung-soc Cc: 'Jonghwan Choi', 'Evgeny Voevodin', 'Tushar Behera' This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). Cc: Jonghwan Choi <jhbird.choi@samsung.com> Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- arch/arm/mach-exynos/mach-nuri.c | 2 ++ arch/arm/mach-exynos/mach-origen.c | 2 ++ arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ 4 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c index 3df8bf4..06c22e0 100644 --- a/arch/arm/mach-exynos/mach-nuri.c +++ b/arch/arm/mach-exynos/mach-nuri.c @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); s5p_fimd0_set_platdata(&nuri_fb_pdata); nuri_camera_init(); diff --git a/arch/arm/mach-exynos/mach-origen.c b/arch/arm/mach-exynos/mach-origen.c index b453464..7cea0be 100644 --- a/arch/arm/mach-exynos/mach-origen.c +++ b/arch/arm/mach-exynos/mach-origen.c @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) s5p_tv_setup(); s5p_i2c_hdmiphy_set_platdata(NULL); + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); s5p_fimd0_set_platdata(&origen_lcd_pdata); platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); diff --git a/arch/arm/mach-exynos/mach-smdkv310.c b/arch/arm/mach-exynos/mach-smdkv310.c index bf2094e..eccd96d 100644 --- a/arch/arm/mach-exynos/mach-smdkv310.c +++ b/arch/arm/mach-exynos/mach-smdkv310.c @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) samsung_keypad_set_platdata(&smdkv310_keypad_data); samsung_bl_set(&smdkv310_bl_gpio_info, &smdkv310_bl_data); + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); smdkv310_ehci_init(); diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c index c38e18d..fe554f1 100644 --- a/arch/arm/mach-exynos/mach-universal_c210.c +++ b/arch/arm/mach-exynos/mach-universal_c210.c @@ -31,6 +31,7 @@ #include <plat/cpu.h> #include <plat/devs.h> #include <plat/iic.h> +#include <plat/clock.h> #include <plat/gpio-cfg.h> #include <plat/fb.h> #include <plat/mfc.h> @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) s5p_i2c_hdmiphy_set_platdata(NULL); i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); s5p_fimd0_set_platdata(&universal_lcd_pdata); universal_touchkey_init(); -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock 2012-01-19 10:16 [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock Jingoo Han @ 2012-01-20 0:53 ` Kyungmin Park 2012-02-10 6:34 ` Evgeny Voevodin 0 siblings, 1 reply; 6+ messages in thread From: Kyungmin Park @ 2012-01-20 0:53 UTC (permalink / raw) To: Jingoo Han Cc: Kukjin Kim, linux-samsung-soc, Jonghwan Choi, Evgeny Voevodin, Tushar Behera On 1/19/12, Jingoo Han <jg1.han@samsung.com> wrote: > This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' > clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd > ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). Hi, Doesn't it better to add common.c? Are there any reason to add each board files? Thank you, Kyungmin Park > > Cc: Jonghwan Choi <jhbird.choi@samsung.com> > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > arch/arm/mach-exynos/mach-nuri.c | 2 ++ > arch/arm/mach-exynos/mach-origen.c | 2 ++ > arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ > arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ > 4 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/mach-nuri.c > b/arch/arm/mach-exynos/mach-nuri.c > index 3df8bf4..06c22e0 100644 > --- a/arch/arm/mach-exynos/mach-nuri.c > +++ b/arch/arm/mach-exynos/mach-nuri.c > @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) > i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); > i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); > > + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); > s5p_fimd0_set_platdata(&nuri_fb_pdata); > > nuri_camera_init(); > diff --git a/arch/arm/mach-exynos/mach-origen.c > b/arch/arm/mach-exynos/mach-origen.c > index b453464..7cea0be 100644 > --- a/arch/arm/mach-exynos/mach-origen.c > +++ b/arch/arm/mach-exynos/mach-origen.c > @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) > s5p_tv_setup(); > s5p_i2c_hdmiphy_set_platdata(NULL); > > + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); > s5p_fimd0_set_platdata(&origen_lcd_pdata); > > platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > diff --git a/arch/arm/mach-exynos/mach-smdkv310.c > b/arch/arm/mach-exynos/mach-smdkv310.c > index bf2094e..eccd96d 100644 > --- a/arch/arm/mach-exynos/mach-smdkv310.c > +++ b/arch/arm/mach-exynos/mach-smdkv310.c > @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) > samsung_keypad_set_platdata(&smdkv310_keypad_data); > > samsung_bl_set(&smdkv310_bl_gpio_info, &smdkv310_bl_data); > + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); > s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); > > smdkv310_ehci_init(); > diff --git a/arch/arm/mach-exynos/mach-universal_c210.c > b/arch/arm/mach-exynos/mach-universal_c210.c > index c38e18d..fe554f1 100644 > --- a/arch/arm/mach-exynos/mach-universal_c210.c > +++ b/arch/arm/mach-exynos/mach-universal_c210.c > @@ -31,6 +31,7 @@ > #include <plat/cpu.h> > #include <plat/devs.h> > #include <plat/iic.h> > +#include <plat/clock.h> > #include <plat/gpio-cfg.h> > #include <plat/fb.h> > #include <plat/mfc.h> > @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) > s5p_i2c_hdmiphy_set_platdata(NULL); > i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); > > + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > + clk_add_alias("lcd", "exynos4-fb.0", "fimd", &s5p_device_fimd0.dev); > s5p_fimd0_set_platdata(&universal_lcd_pdata); > > universal_touchkey_init(); > -- > 1.7.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock 2012-01-20 0:53 ` Kyungmin Park @ 2012-02-10 6:34 ` Evgeny Voevodin 2012-02-10 7:17 ` Jingoo Han 2012-02-10 10:34 ` Jingoo Han 0 siblings, 2 replies; 6+ messages in thread From: Evgeny Voevodin @ 2012-02-10 6:34 UTC (permalink / raw) To: Kyungmin Park Cc: Jingoo Han, Kukjin Kim, linux-samsung-soc, Jonghwan Choi, Tushar Behera, Dmitry Solodkiy On 01/20/2012 04:53 AM, Kyungmin Park wrote: > On 1/19/12, Jingoo Han<jg1.han@samsung.com> wrote: >> This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' >> clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd >> ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). > Hi, > > Doesn't it better to add common.c? > Are there any reason to add each board files? > > Thank you, > Kyungmin Park >> Cc: Jonghwan Choi<jhbird.choi@samsung.com> >> Signed-off-by: Jingoo Han<jg1.han@samsung.com> >> --- >> arch/arm/mach-exynos/mach-nuri.c | 2 ++ >> arch/arm/mach-exynos/mach-origen.c | 2 ++ >> arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ >> arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ >> 4 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/mach-nuri.c >> b/arch/arm/mach-exynos/mach-nuri.c >> index 3df8bf4..06c22e0 100644 >> --- a/arch/arm/mach-exynos/mach-nuri.c >> +++ b/arch/arm/mach-exynos/mach-nuri.c >> @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) >> i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); >> i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); >> >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >> s5p_fimd0_set_platdata(&nuri_fb_pdata); >> >> nuri_camera_init(); >> diff --git a/arch/arm/mach-exynos/mach-origen.c >> b/arch/arm/mach-exynos/mach-origen.c >> index b453464..7cea0be 100644 >> --- a/arch/arm/mach-exynos/mach-origen.c >> +++ b/arch/arm/mach-exynos/mach-origen.c >> @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) >> s5p_tv_setup(); >> s5p_i2c_hdmiphy_set_platdata(NULL); >> >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >> s5p_fimd0_set_platdata(&origen_lcd_pdata); >> >> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); >> diff --git a/arch/arm/mach-exynos/mach-smdkv310.c >> b/arch/arm/mach-exynos/mach-smdkv310.c >> index bf2094e..eccd96d 100644 >> --- a/arch/arm/mach-exynos/mach-smdkv310.c >> +++ b/arch/arm/mach-exynos/mach-smdkv310.c >> @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) >> samsung_keypad_set_platdata(&smdkv310_keypad_data); >> >> samsung_bl_set(&smdkv310_bl_gpio_info,&smdkv310_bl_data); >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >> s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); >> >> smdkv310_ehci_init(); >> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c >> b/arch/arm/mach-exynos/mach-universal_c210.c >> index c38e18d..fe554f1 100644 >> --- a/arch/arm/mach-exynos/mach-universal_c210.c >> +++ b/arch/arm/mach-exynos/mach-universal_c210.c >> @@ -31,6 +31,7 @@ >> #include<plat/cpu.h> >> #include<plat/devs.h> >> #include<plat/iic.h> >> +#include<plat/clock.h> >> #include<plat/gpio-cfg.h> >> #include<plat/fb.h> >> #include<plat/mfc.h> >> @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) >> s5p_i2c_hdmiphy_set_platdata(NULL); >> i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); >> >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >> s5p_fimd0_set_platdata(&universal_lcd_pdata); >> >> universal_touchkey_init(); >> -- >> 1.7.1 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" >> in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Still no appropriate support of frame buffer in the kernel... -- Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock 2012-02-10 6:34 ` Evgeny Voevodin @ 2012-02-10 7:17 ` Jingoo Han 2012-02-10 10:34 ` Jingoo Han 1 sibling, 0 replies; 6+ messages in thread From: Jingoo Han @ 2012-02-10 7:17 UTC (permalink / raw) To: 'Evgeny Voevodin', 'Kyungmin Park' Cc: 'Kukjin Kim', linux-samsung-soc, 'Jonghwan Choi', 'Tushar Behera', 'Dmitry Solodkiy' Hi, Evgeny Voevodin. > -----Original Message----- > From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-owner@vger.kernel.org] On Behalf > Of Evgeny Voevodin > Sent: Friday, February 10, 2012 3:34 PM > To: Kyungmin Park > Cc: Jingoo Han; Kukjin Kim; linux-samsung-soc@vger.kernel.org; Jonghwan Choi; Tushar Behera; Dmitry > Solodkiy > Subject: Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock > > On 01/20/2012 04:53 AM, Kyungmin Park wrote: > > On 1/19/12, Jingoo Han<jg1.han@samsung.com> wrote: > >> This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' > >> clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd > >> ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). > > Hi, > > > > Doesn't it better to add common.c? > > Are there any reason to add each board files? > > > > Thank you, > > Kyungmin Park > >> Cc: Jonghwan Choi<jhbird.choi@samsung.com> > >> Signed-off-by: Jingoo Han<jg1.han@samsung.com> > >> --- > >> arch/arm/mach-exynos/mach-nuri.c | 2 ++ > >> arch/arm/mach-exynos/mach-origen.c | 2 ++ > >> arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ > >> arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ > >> 4 files changed, 9 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/mach-exynos/mach-nuri.c > >> b/arch/arm/mach-exynos/mach-nuri.c > >> index 3df8bf4..06c22e0 100644 > >> --- a/arch/arm/mach-exynos/mach-nuri.c > >> +++ b/arch/arm/mach-exynos/mach-nuri.c > >> @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) > >> i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); > >> i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); > >> > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > >> s5p_fimd0_set_platdata(&nuri_fb_pdata); > >> > >> nuri_camera_init(); > >> diff --git a/arch/arm/mach-exynos/mach-origen.c > >> b/arch/arm/mach-exynos/mach-origen.c > >> index b453464..7cea0be 100644 > >> --- a/arch/arm/mach-exynos/mach-origen.c > >> +++ b/arch/arm/mach-exynos/mach-origen.c > >> @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) > >> s5p_tv_setup(); > >> s5p_i2c_hdmiphy_set_platdata(NULL); > >> > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > >> s5p_fimd0_set_platdata(&origen_lcd_pdata); > >> > >> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > >> diff --git a/arch/arm/mach-exynos/mach-smdkv310.c > >> b/arch/arm/mach-exynos/mach-smdkv310.c > >> index bf2094e..eccd96d 100644 > >> --- a/arch/arm/mach-exynos/mach-smdkv310.c > >> +++ b/arch/arm/mach-exynos/mach-smdkv310.c > >> @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) > >> samsung_keypad_set_platdata(&smdkv310_keypad_data); > >> > >> samsung_bl_set(&smdkv310_bl_gpio_info,&smdkv310_bl_data); > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > >> s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); > >> > >> smdkv310_ehci_init(); > >> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c > >> b/arch/arm/mach-exynos/mach-universal_c210.c > >> index c38e18d..fe554f1 100644 > >> --- a/arch/arm/mach-exynos/mach-universal_c210.c > >> +++ b/arch/arm/mach-exynos/mach-universal_c210.c > >> @@ -31,6 +31,7 @@ > >> #include<plat/cpu.h> > >> #include<plat/devs.h> > >> #include<plat/iic.h> > >> +#include<plat/clock.h> > >> #include<plat/gpio-cfg.h> > >> #include<plat/fb.h> > >> #include<plat/mfc.h> > >> @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) > >> s5p_i2c_hdmiphy_set_platdata(NULL); > >> i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); > >> > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > >> s5p_fimd0_set_platdata(&universal_lcd_pdata); > >> > >> universal_touchkey_init(); > >> -- > >> 1.7.1 > >> > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > >> in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > > Still no appropriate support of frame buffer in the kernel... OK, I will send the new patch. > > -- > Kind regards, > Evgeny Voevodin, > Leading Software Engineer, > ASWG, Moscow R&D center, Samsung Electronics > e-mail: e.voevodin@samsung.com > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock 2012-02-10 6:34 ` Evgeny Voevodin 2012-02-10 7:17 ` Jingoo Han @ 2012-02-10 10:34 ` Jingoo Han 2012-02-20 3:20 ` Tushar Behera 1 sibling, 1 reply; 6+ messages in thread From: Jingoo Han @ 2012-02-10 10:34 UTC (permalink / raw) To: 'Evgeny Voevodin', 'Kyungmin Park' Cc: 'Kukjin Kim', linux-samsung-soc, 'Jonghwan Choi', 'Tushar Behera', 'Dmitry Solodkiy', 'Jingoo Han' > -----Original Message----- > From: Jingoo Han [mailto:jg1.han@samsung.com] > Sent: Friday, February 10, 2012 4:17 PM > To: 'Evgeny Voevodin'; 'Kyungmin Park' > Cc: 'Kukjin Kim'; 'linux-samsung-soc@vger.kernel.org'; 'Jonghwan Choi'; 'Tushar Behera'; 'Dmitry > Solodkiy' > Subject: RE: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock > > > Hi, Evgeny Voevodin. > > -----Original Message----- > > From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-owner@vger.kernel.org] On > Behalf > > Of Evgeny Voevodin > > Sent: Friday, February 10, 2012 3:34 PM > > To: Kyungmin Park > > Cc: Jingoo Han; Kukjin Kim; linux-samsung-soc@vger.kernel.org; Jonghwan Choi; Tushar Behera; Dmitry > > Solodkiy > > Subject: Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock > > > > On 01/20/2012 04:53 AM, Kyungmin Park wrote: > > > On 1/19/12, Jingoo Han<jg1.han@samsung.com> wrote: > > >> This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' > > >> clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd > > >> ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). > > > Hi, > > > > > > Doesn't it better to add common.c? > > > Are there any reason to add each board files? > > > > > > Thank you, > > > Kyungmin Park > > >> Cc: Jonghwan Choi<jhbird.choi@samsung.com> > > >> Signed-off-by: Jingoo Han<jg1.han@samsung.com> > > >> --- > > >> arch/arm/mach-exynos/mach-nuri.c | 2 ++ > > >> arch/arm/mach-exynos/mach-origen.c | 2 ++ > > >> arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ > > >> arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ > > >> 4 files changed, 9 insertions(+), 0 deletions(-) > > >> > > >> diff --git a/arch/arm/mach-exynos/mach-nuri.c > > >> b/arch/arm/mach-exynos/mach-nuri.c > > >> index 3df8bf4..06c22e0 100644 > > >> --- a/arch/arm/mach-exynos/mach-nuri.c > > >> +++ b/arch/arm/mach-exynos/mach-nuri.c > > >> @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) > > >> i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); > > >> i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); > > >> > > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > > >> s5p_fimd0_set_platdata(&nuri_fb_pdata); > > >> > > >> nuri_camera_init(); > > >> diff --git a/arch/arm/mach-exynos/mach-origen.c > > >> b/arch/arm/mach-exynos/mach-origen.c > > >> index b453464..7cea0be 100644 > > >> --- a/arch/arm/mach-exynos/mach-origen.c > > >> +++ b/arch/arm/mach-exynos/mach-origen.c > > >> @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) > > >> s5p_tv_setup(); > > >> s5p_i2c_hdmiphy_set_platdata(NULL); > > >> > > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > > >> s5p_fimd0_set_platdata(&origen_lcd_pdata); > > >> > > >> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > > >> diff --git a/arch/arm/mach-exynos/mach-smdkv310.c > > >> b/arch/arm/mach-exynos/mach-smdkv310.c > > >> index bf2094e..eccd96d 100644 > > >> --- a/arch/arm/mach-exynos/mach-smdkv310.c > > >> +++ b/arch/arm/mach-exynos/mach-smdkv310.c > > >> @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) > > >> samsung_keypad_set_platdata(&smdkv310_keypad_data); > > >> > > >> samsung_bl_set(&smdkv310_bl_gpio_info,&smdkv310_bl_data); > > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > > >> s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); > > >> > > >> smdkv310_ehci_init(); > > >> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c > > >> b/arch/arm/mach-exynos/mach-universal_c210.c > > >> index c38e18d..fe554f1 100644 > > >> --- a/arch/arm/mach-exynos/mach-universal_c210.c > > >> +++ b/arch/arm/mach-exynos/mach-universal_c210.c > > >> @@ -31,6 +31,7 @@ > > >> #include<plat/cpu.h> > > >> #include<plat/devs.h> > > >> #include<plat/iic.h> > > >> +#include<plat/clock.h> > > >> #include<plat/gpio-cfg.h> > > >> #include<plat/fb.h> > > >> #include<plat/mfc.h> > > >> @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) > > >> s5p_i2c_hdmiphy_set_platdata(NULL); > > >> i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); > > >> > > >> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); > > >> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); > > >> s5p_fimd0_set_platdata(&universal_lcd_pdata); > > >> > > >> universal_touchkey_init(); > > >> -- > > >> 1.7.1 > > >> > > >> > > >> -- > > >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > > >> in > > >> the body of a message to majordomo@vger.kernel.org > > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > >> > > > > Still no appropriate support of frame buffer in the kernel... > OK, I will send the new patch. I cannot find good place in common.c. If someone has idea, please let me know good place in common.c. Or, Tushar's patch would be better. http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg07795.html I test this patch, it resolve the lcd clock problem, too. Thanks. > > > > -- > > Kind regards, > > Evgeny Voevodin, > > Leading Software Engineer, > > ASWG, Moscow R&D center, Samsung Electronics > > e-mail: e.voevodin@samsung.com > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock 2012-02-10 10:34 ` Jingoo Han @ 2012-02-20 3:20 ` Tushar Behera 0 siblings, 0 replies; 6+ messages in thread From: Tushar Behera @ 2012-02-20 3:20 UTC (permalink / raw) To: 'Kukjin Kim' Cc: Jingoo Han, 'Evgeny Voevodin', 'Kyungmin Park', linux-samsung-soc, 'Jonghwan Choi', 'Dmitry Solodkiy' Hi Kukjin, On 02/10/2012 04:04 PM, Jingoo Han wrote: > >> -----Original Message----- >> From: Jingoo Han [mailto:jg1.han@samsung.com] >> Sent: Friday, February 10, 2012 4:17 PM >> To: 'Evgeny Voevodin'; 'Kyungmin Park' >> Cc: 'Kukjin Kim'; 'linux-samsung-soc@vger.kernel.org'; 'Jonghwan Choi'; 'Tushar Behera'; 'Dmitry >> Solodkiy' >> Subject: RE: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock >> >> >> Hi, Evgeny Voevodin. >>> -----Original Message----- >>> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-owner@vger.kernel.org] On >> Behalf >>> Of Evgeny Voevodin >>> Sent: Friday, February 10, 2012 3:34 PM >>> To: Kyungmin Park >>> Cc: Jingoo Han; Kukjin Kim; linux-samsung-soc@vger.kernel.org; Jonghwan Choi; Tushar Behera; Dmitry >>> Solodkiy >>> Subject: Re: [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock >>> >>> On 01/20/2012 04:53 AM, Kyungmin Park wrote: >>>> On 1/19/12, Jingoo Han<jg1.han@samsung.com> wrote: >>>>> This patch adds alias name of 'fimd' clock for 'lcd' clock. While 'lcd' >>>>> clock is used for s3c-fb driver, 'fimd' clock is defined for Exynos fimd >>>>> ip. Therefore, 'fimd' clock can be called by using clk_add_alias(). >>>> Hi, >>>> >>>> Doesn't it better to add common.c? >>>> Are there any reason to add each board files? >>>> >>>> Thank you, >>>> Kyungmin Park >>>>> Cc: Jonghwan Choi<jhbird.choi@samsung.com> >>>>> Signed-off-by: Jingoo Han<jg1.han@samsung.com> >>>>> --- >>>>> arch/arm/mach-exynos/mach-nuri.c | 2 ++ >>>>> arch/arm/mach-exynos/mach-origen.c | 2 ++ >>>>> arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ >>>>> arch/arm/mach-exynos/mach-universal_c210.c | 3 +++ >>>>> 4 files changed, 9 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/arch/arm/mach-exynos/mach-nuri.c >>>>> b/arch/arm/mach-exynos/mach-nuri.c >>>>> index 3df8bf4..06c22e0 100644 >>>>> --- a/arch/arm/mach-exynos/mach-nuri.c >>>>> +++ b/arch/arm/mach-exynos/mach-nuri.c >>>>> @@ -1310,6 +1310,8 @@ static void __init nuri_machine_init(void) >>>>> i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); >>>>> i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); >>>>> >>>>> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >>>>> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >>>>> s5p_fimd0_set_platdata(&nuri_fb_pdata); >>>>> >>>>> nuri_camera_init(); >>>>> diff --git a/arch/arm/mach-exynos/mach-origen.c >>>>> b/arch/arm/mach-exynos/mach-origen.c >>>>> index b453464..7cea0be 100644 >>>>> --- a/arch/arm/mach-exynos/mach-origen.c >>>>> +++ b/arch/arm/mach-exynos/mach-origen.c >>>>> @@ -722,6 +722,8 @@ static void __init origen_machine_init(void) >>>>> s5p_tv_setup(); >>>>> s5p_i2c_hdmiphy_set_platdata(NULL); >>>>> >>>>> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >>>>> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >>>>> s5p_fimd0_set_platdata(&origen_lcd_pdata); >>>>> >>>>> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); >>>>> diff --git a/arch/arm/mach-exynos/mach-smdkv310.c >>>>> b/arch/arm/mach-exynos/mach-smdkv310.c >>>>> index bf2094e..eccd96d 100644 >>>>> --- a/arch/arm/mach-exynos/mach-smdkv310.c >>>>> +++ b/arch/arm/mach-exynos/mach-smdkv310.c >>>>> @@ -370,6 +370,8 @@ static void __init smdkv310_machine_init(void) >>>>> samsung_keypad_set_platdata(&smdkv310_keypad_data); >>>>> >>>>> samsung_bl_set(&smdkv310_bl_gpio_info,&smdkv310_bl_data); >>>>> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >>>>> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >>>>> s5p_fimd0_set_platdata(&smdkv310_lcd0_pdata); >>>>> >>>>> smdkv310_ehci_init(); >>>>> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c >>>>> b/arch/arm/mach-exynos/mach-universal_c210.c >>>>> index c38e18d..fe554f1 100644 >>>>> --- a/arch/arm/mach-exynos/mach-universal_c210.c >>>>> +++ b/arch/arm/mach-exynos/mach-universal_c210.c >>>>> @@ -31,6 +31,7 @@ >>>>> #include<plat/cpu.h> >>>>> #include<plat/devs.h> >>>>> #include<plat/iic.h> >>>>> +#include<plat/clock.h> >>>>> #include<plat/gpio-cfg.h> >>>>> #include<plat/fb.h> >>>>> #include<plat/mfc.h> >>>>> @@ -1029,6 +1030,8 @@ static void __init universal_machine_init(void) >>>>> s5p_i2c_hdmiphy_set_platdata(NULL); >>>>> i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs)); >>>>> >>>>> + dev_set_name(&s5p_device_fimd0.dev, "exynos4-fb.0"); >>>>> + clk_add_alias("lcd", "exynos4-fb.0", "fimd",&s5p_device_fimd0.dev); >>>>> s5p_fimd0_set_platdata(&universal_lcd_pdata); >>>>> >>>>> universal_touchkey_init(); >>>>> -- >>>>> 1.7.1 >>>>> >>>>> >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" >>>>> in >>>>> the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>> >>> >>> Still no appropriate support of frame buffer in the kernel... >> OK, I will send the new patch. > I cannot find good place in common.c. > If someone has idea, please let me know good place in common.c. > > Or, Tushar's patch would be better. > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg07795.html > I test this patch, it resolve the lcd clock problem, too. > What is your opinion on this? > Thanks. >>> >>> -- >>> Kind regards, >>> Evgeny Voevodin, >>> Leading Software Engineer, >>> ASWG, Moscow R&D center, Samsung Electronics >>> e-mail: e.voevodin@samsung.com >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Tushar Behera ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-20 3:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-19 10:16 [PATCH] ARM: EXYNOS: Add alias name of 'fimd' clock for 'lcd' clock Jingoo Han 2012-01-20 0:53 ` Kyungmin Park 2012-02-10 6:34 ` Evgeny Voevodin 2012-02-10 7:17 ` Jingoo Han 2012-02-10 10:34 ` Jingoo Han 2012-02-20 3:20 ` Tushar Behera
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.