All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Paul Brook <paul@codesourcery.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"avi@redhat.com" <avi@redhat.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h
Date: Fri, 10 Feb 2012 12:32:23 +0100	[thread overview]
Message-ID: <4F350047.4030507@siemens.com> (raw)
In-Reply-To: <4F34FCF3.4080300@redhat.com>

On 2012-02-10 12:18, Paolo Bonzini wrote:
> On 02/10/2012 12:19 PM, Stefano Stabellini wrote:
>> I think you are right and the right thing to do would be blocking
>> indefinitely.
>> However if slirp doesn't support it, we could have a timeout of 1000 if
>> CONFIG_SLIRP, otherwise block indefinitely.
> 
> You could add a similar hack to qemu_bh_update_timeout for
> slirp_update_timeout.

Real solutions would be preferred, but I know that the code is hairy. In
any case, please no CONFIG_SLIRP code forks.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Paul Brook <paul@codesourcery.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"avi@redhat.com" <avi@redhat.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h
Date: Fri, 10 Feb 2012 12:32:23 +0100	[thread overview]
Message-ID: <4F350047.4030507@siemens.com> (raw)
In-Reply-To: <4F34FCF3.4080300@redhat.com>

On 2012-02-10 12:18, Paolo Bonzini wrote:
> On 02/10/2012 12:19 PM, Stefano Stabellini wrote:
>> I think you are right and the right thing to do would be blocking
>> indefinitely.
>> However if slirp doesn't support it, we could have a timeout of 1000 if
>> CONFIG_SLIRP, otherwise block indefinitely.
> 
> You could add a similar hack to qemu_bh_update_timeout for
> slirp_update_timeout.

Real solutions would be preferred, but I know that the code is hairy. In
any case, please no CONFIG_SLIRP code forks.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-02-10 11:32 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 18:20 [Qemu-devel] [PATCH v3 0/6] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 18:20 ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-01-27 19:09   ` [Qemu-devel] " Jan Kiszka
2012-01-27 19:09     ` Jan Kiszka
2012-01-30 11:39     ` [Qemu-devel] " Stefano Stabellini
2012-01-30 11:39       ` Stefano Stabellini
2012-01-30 15:13       ` [Qemu-devel] " Jan Kiszka
2012-01-30 15:13         ` Jan Kiszka
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-01-27 20:08   ` [Qemu-devel] " Paolo Bonzini
2012-01-27 20:08     ` Paolo Bonzini
2012-01-30 11:58     ` [Qemu-devel] " Stefano Stabellini
2012-01-30 11:58       ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 3/6] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 4/6] timers: the rearm function should be able to handle delta = INT64_MAX Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-01-27 18:21   ` Stefano Stabellini
2012-02-10  0:26   ` [Qemu-devel] " Paul Brook
2012-02-10  0:26     ` Paul Brook
2012-02-10  8:03     ` [Qemu-devel] " Paolo Bonzini
2012-02-10  8:03       ` Paolo Bonzini
2012-02-10  9:52       ` [Qemu-devel] " Paul Brook
2012-02-10  9:52         ` Paul Brook
2012-02-10 10:45         ` [Qemu-devel] " Paolo Bonzini
2012-02-10 10:45           ` Paolo Bonzini
2012-02-10 11:09           ` [Qemu-devel] " Paul Brook
2012-02-10 11:09             ` Paul Brook
2012-02-10 11:19             ` [Qemu-devel] " Stefano Stabellini
2012-02-10 11:19               ` Stefano Stabellini
2012-02-10 11:18               ` [Qemu-devel] " Paolo Bonzini
2012-02-10 11:18                 ` Paolo Bonzini
2012-02-10 11:32                 ` Jan Kiszka [this message]
2012-02-10 11:32                   ` Jan Kiszka
2012-02-10 17:07                   ` [Qemu-devel] " Stefano Stabellini
2012-02-10 17:07                     ` Stefano Stabellini
2012-02-10 23:34                     ` [Qemu-devel] " Paul Brook
2012-02-10 23:34                       ` Paul Brook
2012-02-13 11:52                       ` [Qemu-devel] " Stefano Stabellini
2012-02-13 11:52                         ` Stefano Stabellini
2012-02-14 10:52                         ` [Qemu-devel] " Paul Brook
2012-02-14 10:52                           ` Paul Brook
2012-02-14 11:55                           ` [Qemu-devel] " Stefano Stabellini
2012-02-14 11:55                             ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F350047.4030507@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.