* [ath9k-devel] [PATCH 1/7] ath9k: Remove redundant max_streams assignment
@ 2012-02-13 6:20 ` Sujith Manoharan
0 siblings, 0 replies; 6+ messages in thread
From: Sujith Manoharan @ 2012-02-13 6:20 UTC (permalink / raw)
To: ath9k-devel
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/init.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 53a005d..a625c9a 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,
if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
max_streams = 1;
- else if (AR_SREV_9462(ah))
- max_streams = 2;
else if (AR_SREV_9300_20_OR_LATER(ah))
max_streams = 3;
else
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/7] ath9k: Remove redundant max_streams assignment
@ 2012-02-13 6:20 ` Sujith Manoharan
0 siblings, 0 replies; 6+ messages in thread
From: Sujith Manoharan @ 2012-02-13 6:20 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, ath9k-devel
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/init.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 53a005d..a625c9a 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,
if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
max_streams = 1;
- else if (AR_SREV_9462(ah))
- max_streams = 2;
else if (AR_SREV_9300_20_OR_LATER(ah))
max_streams = 3;
else
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH 1/7] ath9k: Remove redundant max_streams assignment
2012-02-13 6:20 ` Sujith Manoharan
@ 2012-02-13 11:24 ` Felix Fietkau
-1 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2012-02-13 11:24 UTC (permalink / raw)
To: ath9k-devel
On 2012-02-13 7:20 AM, Sujith Manoharan wrote:
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 53a005d..a625c9a 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,
>
> if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
> max_streams = 1;
> - else if (AR_SREV_9462(ah))
> - max_streams = 2;
> else if (AR_SREV_9300_20_OR_LATER(ah))
> max_streams = 3;
> else
I think AR9462 is also matched by AR_SREV_9300_20_OR_LATER(ah), so that
one may not be redundant.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/7] ath9k: Remove redundant max_streams assignment
@ 2012-02-13 11:24 ` Felix Fietkau
0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2012-02-13 11:24 UTC (permalink / raw)
To: Sujith Manoharan; +Cc: linville, linux-wireless, ath9k-devel
On 2012-02-13 7:20 AM, Sujith Manoharan wrote:
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 53a005d..a625c9a 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,
>
> if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
> max_streams = 1;
> - else if (AR_SREV_9462(ah))
> - max_streams = 2;
> else if (AR_SREV_9300_20_OR_LATER(ah))
> max_streams = 3;
> else
I think AR9462 is also matched by AR_SREV_9300_20_OR_LATER(ah), so that
one may not be redundant.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH 1/7] ath9k: Remove redundant max_streams assignment
2012-02-13 11:24 ` Felix Fietkau
@ 2012-02-13 13:07 ` Sujith Manoharan
-1 siblings, 0 replies; 6+ messages in thread
From: Sujith Manoharan @ 2012-02-13 13:07 UTC (permalink / raw)
To: ath9k-devel
Felix Fietkau wrote:
> I think AR9462 is also matched by AR_SREV_9300_20_OR_LATER(ah), so that
> one may not be redundant.
Ah, nice catch.
John, can you please drop this patch ?
Sujith
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-13 13:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-13 6:20 [ath9k-devel] [PATCH 1/7] ath9k: Remove redundant max_streams assignment Sujith Manoharan
2012-02-13 6:20 ` Sujith Manoharan
2012-02-13 11:24 ` [ath9k-devel] " Felix Fietkau
2012-02-13 11:24 ` Felix Fietkau
2012-02-13 13:07 ` [ath9k-devel] " Sujith Manoharan
2012-02-13 13:07 ` Sujith Manoharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.