* [PATCH] mmc: dw_mmc: shift with slot-id for CLKENA register
@ 2012-02-14 8:33 Jaehoon Chung
2012-02-14 10:30 ` Will Newton
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2012-02-14 8:33 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball, Kyungmin Park, Will Newton, James Hogan
In CLKENA register, can support 16-SD card clocks.
If support correctly, must shift with slot-id.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 7d6ad6c..f9457e5 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -652,8 +652,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot)
SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT, 0);
/* enable clock */
- mci_writel(host, CLKENA, SDMMC_CLKEN_ENABLE |
- SDMMC_CLKEN_LOW_PWR);
+ mci_writel(host, CLKENA, ((SDMMC_CLKEN_ENABLE |
+ SDMMC_CLKEN_LOW_PWR) << slot->id));
/* inform CIU */
mci_send_cmd(slot,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: shift with slot-id for CLKENA register
2012-02-14 8:33 [PATCH] mmc: dw_mmc: shift with slot-id for CLKENA register Jaehoon Chung
@ 2012-02-14 10:30 ` Will Newton
2012-02-14 11:28 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Will Newton @ 2012-02-14 10:30 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Chris Ball, Kyungmin Park, James Hogan
On Tue, Feb 14, 2012 at 8:33 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> In CLKENA register, can support 16-SD card clocks.
> If support correctly, must shift with slot-id.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Looks good.
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: shift with slot-id for CLKENA register
2012-02-14 10:30 ` Will Newton
@ 2012-02-14 11:28 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-02-14 11:28 UTC (permalink / raw)
To: Will Newton; +Cc: Jaehoon Chung, linux-mmc, Kyungmin Park, James Hogan
Hi,
On Tue, Feb 14 2012, Will Newton wrote:
> On Tue, Feb 14, 2012 at 8:33 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> In CLKENA register, can support 16-SD card clocks.
>> If support correctly, must shift with slot-id.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Looks good.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-14 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-14 8:33 [PATCH] mmc: dw_mmc: shift with slot-id for CLKENA register Jaehoon Chung
2012-02-14 10:30 ` Will Newton
2012-02-14 11:28 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.