From: "Cousson, Benoit" <b-cousson@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Archit Taneja <archit@ti.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
"Valkeinen, Tomi" <tomi.valkeinen@ti.com>
Subject: Re: OMAP DSS warning in apply.c
Date: Tue, 14 Feb 2012 12:38:22 +0000 [thread overview]
Message-ID: <4F3A55BE.9090109@ti.com> (raw)
In-Reply-To: <20120214120643.GH15338@n2100.arm.linux.org.uk>
+ Tomi
On 2/14/2012 1:06 PM, Russell King - ARM Linux wrote:
> kautobuildv2 discovered this in its omap4430sdp oldconfig build:
>
> drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used
>
> This looks like a valid warning, because wait_pending_extra_info_updates()
> seems to be completely unreferenced. Should the function be removed?
> It looks like extra_updated_completion can also be removed as well, as
> that function is the only place it gets initialized and waited for.
>
> The function also looks weird - it calls extra_info_update_ongoing() first
> under a lock, and then outside the lock. It's not particularly nice API
> wise to have stuff sometimes called under a lock and sometimes not.
WARNING: multiple messages have this Message-ID (diff)
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Archit Taneja <archit@ti.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
"Valkeinen, Tomi" <tomi.valkeinen@ti.com>
Subject: Re: OMAP DSS warning in apply.c
Date: Tue, 14 Feb 2012 13:38:22 +0100 [thread overview]
Message-ID: <4F3A55BE.9090109@ti.com> (raw)
In-Reply-To: <20120214120643.GH15338@n2100.arm.linux.org.uk>
+ Tomi
On 2/14/2012 1:06 PM, Russell King - ARM Linux wrote:
> kautobuildv2 discovered this in its omap4430sdp oldconfig build:
>
> drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used
>
> This looks like a valid warning, because wait_pending_extra_info_updates()
> seems to be completely unreferenced. Should the function be removed?
> It looks like extra_updated_completion can also be removed as well, as
> that function is the only place it gets initialized and waited for.
>
> The function also looks weird - it calls extra_info_update_ongoing() first
> under a lock, and then outside the lock. It's not particularly nice API
> wise to have stuff sometimes called under a lock and sometimes not.
next prev parent reply other threads:[~2012-02-14 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 12:06 OMAP DSS warning in apply.c Russell King - ARM Linux
2012-02-14 12:38 ` Cousson, Benoit [this message]
2012-02-14 12:38 ` Cousson, Benoit
2012-02-14 12:57 ` Tomi Valkeinen
2012-02-14 12:57 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A55BE.9090109@ti.com \
--to=b-cousson@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.