From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] i386: Remove REGPARM
Date: Wed, 15 Feb 2012 11:36:16 -0800 [thread overview]
Message-ID: <4F3C0930.7010407@twiddle.net> (raw)
In-Reply-To: <CAAu8pHvEDw_3mrdYh7xPtHJGcejpdNruWKWZux3WEQECzn228g@mail.gmail.com>
On 02/15/2012 10:11 AM, Blue Swirl wrote:
> #if defined(CONFIG_SOFTMMU)
> - int mem_index, s_bits, arg_idx;
> + int mem_index, s_bits;
> +#if TCG_TARGET_REG_BITS == 64
> + int arg_idx;
> +#else
> + int stack_adjust;
> +#endif
...
> - if (TCG_TARGET_REG_BITS == 64) {
> - tcg_out_mov(s, (opc == 3 ? TCG_TYPE_I64 : TCG_TYPE_I32),
...
> +#if TCG_TARGET_REG_BITS == 32
> + tcg_out_pushi(s, mem_index);
Any particular reason you didn't continue with the C-if form,
so that you could avoid the extra ifdeffery at the top there?
r~
next prev parent reply other threads:[~2012-02-15 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:11 [Qemu-devel] [PATCH] i386: Remove REGPARM Blue Swirl
2012-02-15 19:36 ` Richard Henderson [this message]
2012-02-15 20:05 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3C0930.7010407@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.