From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: David Ahern <dsahern@gmail.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/3] KVM: perf: kvm events analysis tool
Date: Thu, 16 Feb 2012 12:59:43 +0800 [thread overview]
Message-ID: <4F3C8D3F.9010105@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F3931D6.2090305@gmail.com>
On 02/13/2012 11:52 PM, David Ahern wrote:
>> The first patch is only needed for code compilation, after kvm-events is
>> compiled, you can analyse any kernels. :)
>
> understood.
>
> Now that I recall perf's way of handling out of tree builds, a couple of
> comments:
>
> 1. you need to add the following to tools/perf/MANIFEST
> arch/x86/include/asm/svm.h
> arch/x86/include/asm/vmx.h
> arch/x86/include/asm/kvm_host.h
>
Right.
> 2.scripts/checkpatch.pl is an unhappy camper.
>
It seems checkpath always complains about TRACE_EVENT and many more
than-80-characters lines in perf tools.
> I'll take a look at the code and try out the command when I get some time.
>
Okay, i will post the next version after collecting your new comments!
Thanks for your time, David! :)
next prev parent reply other threads:[~2012-02-16 4:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 5:32 [PATCH 3/3] KVM: perf: kvm events analysis tool David Ahern
2012-02-13 5:32 ` David Ahern
2012-02-13 10:06 ` Xiao Guangrong
2012-02-13 15:52 ` David Ahern
2012-02-16 4:59 ` Xiao Guangrong [this message]
2012-02-16 5:05 ` David Ahern
2012-02-16 5:33 ` Xiao Guangrong
2012-02-16 16:35 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2012-03-06 8:55 [PATCH v5 0/3] " Xiao Guangrong
2012-03-06 8:58 ` [PATCH 3/3] " Xiao Guangrong
2012-02-09 9:06 [PATCH v4 0/3] " Xiao Guangrong
2012-02-09 9:09 ` [PATCH 3/3] " Xiao Guangrong
2012-02-13 3:04 ` David Ahern
2012-02-13 5:00 ` Xiao Guangrong
2012-02-20 23:47 ` David Ahern
2012-02-21 3:52 ` Xiao Guangrong
2012-02-21 4:58 ` David Ahern
2012-02-27 4:57 ` Xiao Guangrong
2012-01-16 9:30 [RFC][PATCH] KVM: perf: a smart tool to analyse kvm events Xiao Guangrong
2012-01-16 9:32 ` [PATCH 3/3] KVM: perf: kvm events analysis tool Xiao Guangrong
2012-01-16 10:04 ` Avi Kivity
2012-01-17 2:30 ` Xiao Guangrong
2012-01-24 12:49 ` Avi Kivity
2012-01-16 10:08 ` Stefan Hajnoczi
2012-01-17 2:37 ` Xiao Guangrong
2012-01-17 11:59 ` Marcelo Tosatti
2012-01-24 12:51 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3C8D3F.9010105@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=acme@infradead.org \
--cc=avi@redhat.com \
--cc=dsahern@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.