From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: remove rx_bufptr
Date: Thu, 16 Feb 2012 08:38:28 +0100 [thread overview]
Message-ID: <4F3CB274.1080800@openwrt.org> (raw)
In-Reply-To: <1329375781-4902-1-git-send-email-mohammed@qca.qualcomm.com>
On 2012-02-16 8:03 AM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> it does not seems to used for anything
>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/ath9k.h | 1 -
> drivers/net/wireless/ath/ath9k/recv.c | 4 ----
> 2 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
> index 171ccf7..603f686 100644
> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
> @@ -311,7 +311,6 @@ struct ath_rx {
> spinlock_t rxbuflock;
> struct list_head rxbuf;
> struct ath_descdma rxdma;
> - struct ath_buf *rx_bufptr;
> struct ath_rx_edma rx_edma[ATH9K_RX_QUEUE_MAX];
>
> struct sk_buff *frag;
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 7e1a91a..c9612d9 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -224,9 +224,6 @@ static void ath_rx_edma_cleanup(struct ath_softc *sc)
> }
>
> INIT_LIST_HEAD(&sc->rx.rxbuf);
> -
> - kfree(sc->rx.rx_bufptr);
> - sc->rx.rx_bufptr = NULL;
> }
>
Take a look at this part. It's used for avoiding a memleak, so please
keep it ;)
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Mohammed@venema.h4ckr.net, ath9k-devel@lists.ath9k.org,
linux-wireless@vger.kernel.org,
Rodriguez Luis <rodrigue@qca.qualcomm.com>
Subject: Re: [RFC] ath9k: remove rx_bufptr
Date: Thu, 16 Feb 2012 08:38:28 +0100 [thread overview]
Message-ID: <4F3CB274.1080800@openwrt.org> (raw)
In-Reply-To: <1329375781-4902-1-git-send-email-mohammed@qca.qualcomm.com>
On 2012-02-16 8:03 AM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> it does not seems to used for anything
>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/ath9k.h | 1 -
> drivers/net/wireless/ath/ath9k/recv.c | 4 ----
> 2 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
> index 171ccf7..603f686 100644
> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
> @@ -311,7 +311,6 @@ struct ath_rx {
> spinlock_t rxbuflock;
> struct list_head rxbuf;
> struct ath_descdma rxdma;
> - struct ath_buf *rx_bufptr;
> struct ath_rx_edma rx_edma[ATH9K_RX_QUEUE_MAX];
>
> struct sk_buff *frag;
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 7e1a91a..c9612d9 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -224,9 +224,6 @@ static void ath_rx_edma_cleanup(struct ath_softc *sc)
> }
>
> INIT_LIST_HEAD(&sc->rx.rxbuf);
> -
> - kfree(sc->rx.rx_bufptr);
> - sc->rx.rx_bufptr = NULL;
> }
>
Take a look at this part. It's used for avoiding a memleak, so please
keep it ;)
next prev parent reply other threads:[~2012-02-16 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 7:03 [ath9k-devel] [RFC] ath9k: remove rx_bufptr Mohammed Shafi Shajakhan
2012-02-16 7:03 ` Mohammed Shafi Shajakhan
2012-02-16 7:38 ` Felix Fietkau [this message]
2012-02-16 7:38 ` Felix Fietkau
2012-02-16 8:16 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-02-16 8:16 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3CB274.1080800@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.