* [PATCH] completion: --list option for git-branch
@ 2012-02-15 20:36 Ralf Thielow
2012-02-16 9:28 ` Zbigniew Jędrzejewski-Szmek
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Thielow @ 2012-02-15 20:36 UTC (permalink / raw)
To: spearce; +Cc: git, gitster, Ralf Thielow
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d7367e9..1505cff 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1137,7 +1137,7 @@ _git_branch ()
__gitcomp "
--color --no-color --verbose --abbrev= --no-abbrev
--track --no-track --contains --merged --no-merged
- --set-upstream --edit-description
+ --set-upstream --edit-description --list
"
;;
*)
--
1.7.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] completion: --list option for git-branch
2012-02-15 20:36 [PATCH] completion: --list option for git-branch Ralf Thielow
@ 2012-02-16 9:28 ` Zbigniew Jędrzejewski-Szmek
2012-02-16 18:07 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Zbigniew Jędrzejewski-Szmek @ 2012-02-16 9:28 UTC (permalink / raw)
To: Ralf Thielow; +Cc: spearce, git, gitster
On 02/15/2012 09:36 PM, Ralf Thielow wrote:
> Signed-off-by: Ralf Thielow<ralf.thielow@googlemail.com>
> ---
> contrib/completion/git-completion.bash | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d7367e9..1505cff 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1137,7 +1137,7 @@ _git_branch ()
> __gitcomp "
> --color --no-color --verbose --abbrev= --no-abbrev
> --track --no-track --contains --merged --no-merged
> - --set-upstream --edit-description
> + --set-upstream --edit-description --list
> "
> ;;
> *)
Normally one would use just a bare 'git branch' to list branches.
Why would you want to use --list in an interactive environment (as
opposed to a script)? Isn't it better not to clutter the completion
options with something that the user actually has not need for?
Zbyszek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] completion: --list option for git-branch
2012-02-16 9:28 ` Zbigniew Jędrzejewski-Szmek
@ 2012-02-16 18:07 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2012-02-16 18:07 UTC (permalink / raw)
To: Zbigniew Jędrzejewski-Szmek; +Cc: Ralf Thielow, spearce, git
Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> Normally one would use just a bare 'git branch' to list branches.
> Why would you want to use --list in an interactive environment (as
> opposed to a script)? Isn't it better not to clutter the completion
> options with something that the user actually has not need for?
$ git branch jc/\*
fatal: 'jc/*' is not a valid branch name.
$ git branch --list jc/\*
jc/advise-i18n
jc/advise-push-default
...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-16 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-15 20:36 [PATCH] completion: --list option for git-branch Ralf Thielow
2012-02-16 9:28 ` Zbigniew Jędrzejewski-Szmek
2012-02-16 18:07 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.