From: Phillip Susi <psusi@ubuntu.com>
To: Ted Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] e2image: add -a switch to include all data
Date: Thu, 16 Feb 2012 19:17:55 -0500 [thread overview]
Message-ID: <4F3D9CB3.4020704@ubuntu.com> (raw)
In-Reply-To: <20120216231745.GC26473@thunk.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/16/2012 06:17 PM, Ted Ts'o wrote:
> As I recall Lukas disclaimed a guarantee that the code would work on
> qcow2 images that weren't generated by e2image. (In particular, it
> definitely doesn't support compressed or encrypted qcow2 images.)
>
> So we need to make sure we add the appropriate disclaimers that this
> might not work on qcow2 images generated by tools other than e2image.
Would you care to craft such a disclaimer?
> It will only work for raw images. The QCOW2 format uses an entirely
> different code path, since we don't have an QCOW2 io_manager
> abstraction. That was my original hope, but that's not how our qcow2
> support was implemented, so it won't work, and we should probably give
> a reasonable warning if someone tries to use the -a flag with anything
> other than a raw file system image for e2image's input.
It seemed to work fine with qcow2 when I tested it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPPZyzAAoJEJrBOlT6nu75U2UIAMgAF/+pIFQCiXCQGMqt+6rR
4k2P2Q/NfRIIf5lSuNaMCuV88ZuUU002ywEN6z9hPfxXDIagDAzOArtVI2nAhwfz
Z4BF7uJ+7eJDCDQycNDb4JmAQDRs2sBuu3Y0dHKWthyd39KYMR7B0ARwCSeYLczB
eigCiQwTVechP2jacWwNnv53BP2xbw/BYy5IHfQViSKijxGNdheQkYqOTIO5eGGB
NdPx5A6yogLOHyB3K3E9cqEnAjXSlelLH7sRCPAmHmQiJVscAiNZ6JvyP/oV0uek
HlmvP0LyZwzMvy8XlgoybHNRLysw+VEVVuLIrAzZJHiW7aWH3WPtqrPEQp6XoJY=
=cmZg
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-02-17 0:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 21:35 [PATCH 1/2] e2image: truncate raw image file to correct size Phillip Susi
2012-02-16 21:35 ` [PATCH 2/2] e2image: add -a switch to include all data Phillip Susi
2012-02-16 23:17 ` Ted Ts'o
2012-02-17 0:17 ` Phillip Susi [this message]
2012-02-17 9:17 ` Lukas Czerner
2012-02-17 14:50 ` Ted Ts'o
2012-02-17 15:35 ` Lukas Czerner
2012-02-17 15:39 ` Lukas Czerner
2012-02-17 20:39 ` Ted Ts'o
2012-02-16 22:58 ` [PATCH 1/2] e2image: truncate raw image file to correct size Ted Ts'o
2012-02-16 23:10 ` Phillip Susi
2012-02-16 23:30 ` Ted Ts'o
2012-02-17 0:21 ` Phillip Susi
2012-02-17 10:04 ` Lukas Czerner
2012-02-17 14:30 ` Ted Ts'o
2012-02-17 14:32 ` [PATCH 1/2] e2image: fix logic bug which could cause a raw image not to be extended Theodore Ts'o
2012-02-17 14:32 ` [PATCH 2/2] e2image: attempt to use ftruncate64 to set i_size for raw images Theodore Ts'o
2012-02-17 14:35 ` [PATCH 2/2 -v2] " Theodore Ts'o
2012-02-17 20:19 ` Lukas Czerner
2012-02-17 20:18 ` [PATCH 1/2] e2image: fix logic bug which could cause a raw image not to be extended Lukas Czerner
2012-02-17 14:46 ` [PATCH 1/2] e2image: truncate raw image file to correct size Phillip Susi
2012-02-17 14:31 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3D9CB3.4020704@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.