From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Danny Kukawka <dkukawka@suse.de>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Steven Rostedt <rostedt@goodmis.org>,
Jovi Zhang <bookjovi@gmail.com>,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH] tools/perf/util/probe-event.c included string.h twice
Date: Fri, 17 Feb 2012 15:04:07 +0900 [thread overview]
Message-ID: <4F3DEDD7.6090804@hitachi.com> (raw)
In-Reply-To: <1329400459-31570-1-git-send-email-danny.kukawka@bisect.de>
(2012/02/16 22:54), Danny Kukawka wrote:
> tools/perf/util/probe-event.c included 'string.h' twice,
> remove the duplicate.
Right, since perf-defined string util functions(in util/string.c)
are declared in util.h, not string.h.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitahi.com>
Thank you!
> ---
> tools/perf/util/probe-event.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 29cb654..8ce8356 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -34,7 +34,6 @@
>
> #include "util.h"
> #include "event.h"
> -#include "string.h"
> #include "strlist.h"
> #include "debug.h"
> #include "cache.h"
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2012-02-17 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:54 [PATCH] tools/perf/util/probe-event.c included string.h twice Danny Kukawka
2012-02-17 6:04 ` Masami Hiramatsu [this message]
2012-02-22 16:02 ` [tip:perf/core] perf tools: Remove duplicated string.h includes tip-bot for Danny Kukawka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3DEDD7.6090804@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=bookjovi@gmail.com \
--cc=danny.kukawka@bisect.de \
--cc=dkukawka@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.