[PATCH] tools/perf/util/probe-event.c included string.h twice

[PATCH] tools/perf/util/probe-event.c included string.h twice

[Danny Kukawka]

tools/perf/util/probe-event.c included 'string.h' twice,
remove the duplicate.

Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
 tools/perf/util/probe-event.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 29cb654..8ce8356 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -34,7 +34,6 @@
 
 #include "util.h"
 #include "event.h"
-#include "string.h"
 #include "strlist.h"
 #include "debug.h"
 #include "cache.h"
-- 
1.7.8.3

Re: [PATCH] tools/perf/util/probe-event.c included string.h twice

[Masami Hiramatsu]

(2012/02/16 22:54), Danny Kukawka wrote:
> tools/perf/util/probe-event.c included 'string.h' twice,
> remove the duplicate.

Right, since perf-defined string util functions(in util/string.c)
are declared in util.h, not string.h.

> 
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitahi.com>

Thank you!

> ---
>  tools/perf/util/probe-event.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 29cb654..8ce8356 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -34,7 +34,6 @@
>  
>  #include "util.h"
>  #include "event.h"
> -#include "string.h"
>  #include "strlist.h"
>  #include "debug.h"
>  #include "cache.h"


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

[tip:perf/core] perf tools: Remove duplicated string.h includes

[tip-bot for Danny Kukawka]

Commit-ID:  dfd3b1e3e8a580bcbf854d46ae0f22c8333e82d8
Gitweb:     http://git.kernel.org/tip/dfd3b1e3e8a580bcbf854d46ae0f22c8333e82d8
Author:     Danny Kukawka <danny.kukawka@bisect.de>
AuthorDate: Thu, 16 Feb 2012 14:54:19 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 17 Feb 2012 16:34:09 -0200

perf tools: Remove duplicated string.h includes

tools/perf/util/probe-event.c included 'string.h' twice, remove the
duplicate.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Danny Kukawka <dkukawka@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jovi Zhang <bookjovi@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1329400459-31570-1-git-send-email-danny.kukawka@bisect.de
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index c1a513e..8379252 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -34,7 +34,6 @@
 
 #include "util.h"
 #include "event.h"
-#include "string.h"
 #include "strlist.h"
 #include "debug.h"
 #include "cache.h"