Re: [PATCH v4.1] can/sja1000: add support for PEAK-System PCMCIA card

[Oliver Hartkopp <oliver.hartkopp@volkswagen.de>]

On 17.02.2012 10:36, Marc Kleine-Budde wrote:
> On 02/17/2012 10:21 AM, Stephane Grosjean wrote:
>> Hi Oliver,
>>
>> I've got one (newbie) question: what is the next step? I mean, should I
>> post the same patch again but with this "Acked-by"? Or what? Should I
>> wait for any linux-can Acked-by ?
>
> No need to repost so soon. A Tested-by from Oliver under heavy load
> detaching together with the Fix unplug Patch would be fine.
>

I can confirm that with together with this patch
"[PATCH v2] can: sja1000 fix isr hang when hw is unplugged under load"

http://marc.info/?l=linux-can&m=132932474901518&w=2

there is no freeze on my Dell830 when unplugging the PEAK PCMCIA Card.

Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>

Indeed i got some 'last famous CAN frames' on plug out like this:

can0  10 [8] 37 00 FF FF FF FF FF FF

while it should have been

can0  10 [8] 37 00 00 00 00 00 00 00

So the last message can contain rubbish but it doesn't freeze the machine
anymore. The behavior is now just like we discussed it :-)

I also did not get any freezes with the PEAK PCIeC anymore.

The only remaining issue with PEAK PCIeC is the locking warning about the
PCIeC LED timer lock (&card->led_timer) when i enable and start the interface
under CAN load. I do have a peak_pci v5 driver here - but in v6 only changed
the device_id table right?

To get this problem you need to connect the PCIeC to a CAN bus which is 
already having CAN traffic between at least two functional nodes.

Regards,
Oliver