Re: [Qemu-devel] [PATCH v4 2/3] jazz-led: convert to QOM

["Andreas Färber" <afaerber@suse.de>]

Am 17.02.2012 20:27, schrieb Hervé Poussineau:
> Some simplifications in I/O functions are possible because
> Jazz LED only registers one byte of I/O.
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/jazz_led.c  |  159 +++++++++++++++++++++++++-------------------------------
>  hw/mips.h      |    3 -
>  hw/mips_jazz.c |    2 +-
>  3 files changed, 71 insertions(+), 93 deletions(-)
> 
> diff --git a/hw/jazz_led.c b/hw/jazz_led.c
> index 1af9268..5d8040b 100644
> --- a/hw/jazz_led.c
> +++ b/hw/jazz_led.c
> @@ -1,7 +1,7 @@
>  /*
>   * QEMU JAZZ LED emulator.
>   *
> - * Copyright (c) 2007 Hervé Poussineau
> + * Copyright (c) 2007-2012 Herve Poussineau

Did you intentionally drop the accent from your name?

> +static void jazz_led_register(void)

The convention recently introduced would be jazz_led_register_types.

> +{
> +    type_register_static(&jazz_led_info);
> +}
> +
> +type_init(jazz_led_register);

No semicolon necessary.

The ops change looks good, and we're still stuck with SysBus for a bit
so just these minor nits.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg