All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial)
@ 2012-02-17 19:42 Florian Haas
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Haas @ 2012-02-17 19:42 UTC (permalink / raw)
  To: ceph-devel; +Cc: Florian Haas

Creating a snapshot requires using "rbd snap create",
as opposed to just "rbd create". Also for purposes of
clarification, add note that removing a snapshot similarly
requires "rbd snap rm".

Thanks to Josh Durgin for the explanation on IRC.
---
 man/rbd.8 |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/man/rbd.8 b/man/rbd.8
index 0278137..b59c2f6 100644
--- a/man/rbd.8
+++ b/man/rbd.8
@@ -194,7 +194,15 @@ To create a new snapshot:
 .sp
 .nf
 .ft C
-rbd create mypool/myimage@mysnap
+rbd snap create mypool/myimage@mysnap
+.ft P
+.fi
+.sp
+To delete a snapshot:
+.sp
+.nf
+.ft C
+rbd snap rm mypool/myimage@mysnap
 .ft P
 .fi
 .sp
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Updated rbd man page patch
@ 2012-02-17 20:15 Florian Haas
  2012-02-17 20:15 ` [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial) Florian Haas
  0 siblings, 1 reply; 4+ messages in thread
From: Florian Haas @ 2012-02-17 20:15 UTC (permalink / raw)
  To: ceph-devel

Hi,

updated version of the previous patch, after Josh pointed out that
I patched the generated man page, rather than its source.

Cheers,
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial)
  2012-02-17 20:15 Updated rbd man page patch Florian Haas
@ 2012-02-17 20:15 ` Florian Haas
  2012-02-17 22:33   ` Josh Durgin
  0 siblings, 1 reply; 4+ messages in thread
From: Florian Haas @ 2012-02-17 20:15 UTC (permalink / raw)
  To: ceph-devel; +Cc: Florian Haas

Creating a snapshot requires using "rbd snap create",
as opposed to just "rbd create". Also for purposes of
clarification, add note that removing a snapshot similarly
requires "rbd snap rm".

Thanks to Josh Durgin for the explanation on IRC.

Signed-off-by: Florian Haas <florian@hastexo.com>
---
 doc/man/8/rbd.rst |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/doc/man/8/rbd.rst b/doc/man/8/rbd.rst
index fbf8e3c..7069e30 100644
--- a/doc/man/8/rbd.rst
+++ b/doc/man/8/rbd.rst
@@ -154,7 +154,11 @@ To delete an rbd image (be careful!)::
 
 To create a new snapshot::
 
-       rbd create mypool/myimage@mysnap
+       rbd snap create mypool/myimage@mysnap
+
+To delete a snapshot::
+
+       rbd snap rm mypool/myimage@mysnap
 
 To map an image via the kernel with cephx enabled::
 
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial)
  2012-02-17 20:15 ` [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial) Florian Haas
@ 2012-02-17 22:33   ` Josh Durgin
  0 siblings, 0 replies; 4+ messages in thread
From: Josh Durgin @ 2012-02-17 22:33 UTC (permalink / raw)
  To: Florian Haas; +Cc: ceph-devel

On 02/17/2012 12:15 PM, Florian Haas wrote:
> Creating a snapshot requires using "rbd snap create",
> as opposed to just "rbd create". Also for purposes of
> clarification, add note that removing a snapshot similarly
> requires "rbd snap rm".
>
> Thanks to Josh Durgin for the explanation on IRC.
>
> Signed-off-by: Florian Haas<florian@hastexo.com>
> ---
>   doc/man/8/rbd.rst |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/doc/man/8/rbd.rst b/doc/man/8/rbd.rst
> index fbf8e3c..7069e30 100644
> --- a/doc/man/8/rbd.rst
> +++ b/doc/man/8/rbd.rst
> @@ -154,7 +154,11 @@ To delete an rbd image (be careful!)::
>
>   To create a new snapshot::
>
> -       rbd create mypool/myimage@mysnap
> +       rbd snap create mypool/myimage@mysnap
> +
> +To delete a snapshot::
> +
> +       rbd snap rm mypool/myimage@mysnap
>
>   To map an image via the kernel with cephx enabled::
>

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-17 22:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 20:15 Updated rbd man page patch Florian Haas
2012-02-17 20:15 ` [PATCH] doc: fix snapshot creation/deletion syntax in rbd man page (trivial) Florian Haas
2012-02-17 22:33   ` Josh Durgin
  -- strict thread matches above, loose matches on Subject: below --
2012-02-17 19:42 Florian Haas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.