All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] integrator: stop calling pci_init() twice
Date: Sat, 18 Feb 2012 12:22:34 +0100	[thread overview]
Message-ID: <4F3F89FA.8030206@aribaud.net> (raw)
In-Reply-To: <1327187599-26076-1-git-send-email-linus.walleij@linaro.org>

Hi Linus,

Le 22/01/2012 00:13, Linus Walleij a ?crit :
> The U-Boot startup infrastructure already makes sure pci_init() is
> called at a proper time, calling it again from within the board
> setup code will not make things better.
>
> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>
> ---
>   board/armltd/integrator/integrator.c |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
> index a507c09..4658ac1 100644
> --- a/board/armltd/integrator/integrator.c
> +++ b/board/armltd/integrator/integrator.c
> @@ -115,9 +115,6 @@ extern void cm_remap(void);
>
>   int misc_init_r (void)
>   {
> -#ifdef CONFIG_PCI
> -	pci_init();
> -#endif
>   	setenv("verify", "n");
>   	return (0);
>   }

Applied to u-boot-arm/master as a potential bug fix.

Amicalement,
-- 
Albert.

      reply	other threads:[~2012-02-18 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-21 23:13 [U-Boot] [PATCH] integrator: stop calling pci_init() twice Linus Walleij
2012-02-18 11:22 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3F89FA.8030206@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.