* [U-Boot] [PATCH] integrator: stop calling pci_init() twice
@ 2012-01-21 23:13 Linus Walleij
2012-02-18 11:22 ` Albert ARIBAUD
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2012-01-21 23:13 UTC (permalink / raw)
To: u-boot
The U-Boot startup infrastructure already makes sure pci_init() is
called at a proper time, calling it again from within the board
setup code will not make things better.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
board/armltd/integrator/integrator.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
index a507c09..4658ac1 100644
--- a/board/armltd/integrator/integrator.c
+++ b/board/armltd/integrator/integrator.c
@@ -115,9 +115,6 @@ extern void cm_remap(void);
int misc_init_r (void)
{
-#ifdef CONFIG_PCI
- pci_init();
-#endif
setenv("verify", "n");
return (0);
}
--
1.7.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] integrator: stop calling pci_init() twice
2012-01-21 23:13 [U-Boot] [PATCH] integrator: stop calling pci_init() twice Linus Walleij
@ 2012-02-18 11:22 ` Albert ARIBAUD
0 siblings, 0 replies; 2+ messages in thread
From: Albert ARIBAUD @ 2012-02-18 11:22 UTC (permalink / raw)
To: u-boot
Hi Linus,
Le 22/01/2012 00:13, Linus Walleij a ?crit :
> The U-Boot startup infrastructure already makes sure pci_init() is
> called at a proper time, calling it again from within the board
> setup code will not make things better.
>
> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>
> ---
> board/armltd/integrator/integrator.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
> index a507c09..4658ac1 100644
> --- a/board/armltd/integrator/integrator.c
> +++ b/board/armltd/integrator/integrator.c
> @@ -115,9 +115,6 @@ extern void cm_remap(void);
>
> int misc_init_r (void)
> {
> -#ifdef CONFIG_PCI
> - pci_init();
> -#endif
> setenv("verify", "n");
> return (0);
> }
Applied to u-boot-arm/master as a potential bug fix.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-18 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-21 23:13 [U-Boot] [PATCH] integrator: stop calling pci_init() twice Linus Walleij
2012-02-18 11:22 ` Albert ARIBAUD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.