From: Shubhrajyoti <shubhrajyoti@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>,
"Govindraj \".\" R" <govindraj.raja@ti.com>
Subject: Re: [PATCH 2/2] ARM: OMAP2: remove some orphan function declarations.
Date: Sun, 19 Feb 2012 19:06:00 +0530 [thread overview]
Message-ID: <4F40FAC0.3010306@ti.com> (raw)
In-Reply-To: <20120219022931.8254.29652.stgit@notabene.brown>
On Sunday 19 February 2012 07:59 AM, NeilBrown wrote:
> commit 2fd149645eb removed omap_uart_can_sleep and omap3_can_sleep,
> but not their declarations. So remove those now.
>
a small description with the commit id would have been good.
Looks good to me.
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>
thanks.
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>
> arch/arm/mach-omap2/pm.h | 1 -
> arch/arm/plat-omap/include/plat/serial.h | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b737b11..6cd954d 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -18,7 +18,6 @@
> extern void *omap3_secure_ram_storage;
> extern void omap3_pm_off_mode_enable(int);
> extern void omap_sram_idle(void);
> -extern int omap3_can_sleep(void);
> extern int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
> extern int omap3_idle_init(void);
> extern int omap4_idle_init(void);
> diff --git a/arch/arm/plat-omap/include/plat/serial.h b/arch/arm/plat-omap/include/plat/serial.h
> index 198d1e6..b073e5f 100644
> --- a/arch/arm/plat-omap/include/plat/serial.h
> +++ b/arch/arm/plat-omap/include/plat/serial.h
> @@ -110,7 +110,6 @@ struct omap_board_data;
> struct omap_uart_port_info;
>
> extern void omap_serial_init(void);
> -extern int omap_uart_can_sleep(void);
> extern void omap_serial_board_init(struct omap_uart_port_info *platform_data);
> extern void omap_serial_init_port(struct omap_board_data *bdata,
> struct omap_uart_port_info *platform_data);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP2: remove some orphan function declarations.
Date: Sun, 19 Feb 2012 19:06:00 +0530 [thread overview]
Message-ID: <4F40FAC0.3010306@ti.com> (raw)
In-Reply-To: <20120219022931.8254.29652.stgit@notabene.brown>
On Sunday 19 February 2012 07:59 AM, NeilBrown wrote:
> commit 2fd149645eb removed omap_uart_can_sleep and omap3_can_sleep,
> but not their declarations. So remove those now.
>
a small description with the commit id would have been good.
Looks good to me.
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>
thanks.
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>
> arch/arm/mach-omap2/pm.h | 1 -
> arch/arm/plat-omap/include/plat/serial.h | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b737b11..6cd954d 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -18,7 +18,6 @@
> extern void *omap3_secure_ram_storage;
> extern void omap3_pm_off_mode_enable(int);
> extern void omap_sram_idle(void);
> -extern int omap3_can_sleep(void);
> extern int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
> extern int omap3_idle_init(void);
> extern int omap4_idle_init(void);
> diff --git a/arch/arm/plat-omap/include/plat/serial.h b/arch/arm/plat-omap/include/plat/serial.h
> index 198d1e6..b073e5f 100644
> --- a/arch/arm/plat-omap/include/plat/serial.h
> +++ b/arch/arm/plat-omap/include/plat/serial.h
> @@ -110,7 +110,6 @@ struct omap_board_data;
> struct omap_uart_port_info;
>
> extern void omap_serial_init(void);
> -extern int omap_uart_can_sleep(void);
> extern void omap_serial_board_init(struct omap_uart_port_info *platform_data);
> extern void omap_serial_init_port(struct omap_board_data *bdata,
> struct omap_uart_port_info *platform_data);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-19 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 2:29 [PATCH 0/2] Two trivial omap/serial patches NeilBrown
2012-02-19 2:29 ` NeilBrown
2012-02-19 2:29 ` [PATCH 1/2] ARM: OMAP2+: UART: remove unused fields in omap_uart_state NeilBrown
2012-02-19 2:29 ` NeilBrown
2012-02-19 16:10 ` Sergei Shtylyov
2012-02-19 16:10 ` Sergei Shtylyov
2012-02-19 2:29 ` [PATCH 2/2] ARM: OMAP2: remove some orphan function declarations NeilBrown
2012-02-19 2:29 ` NeilBrown
2012-02-19 13:36 ` Shubhrajyoti [this message]
2012-02-19 13:36 ` Shubhrajyoti
2012-02-19 16:09 ` Sergei Shtylyov
2012-02-19 16:09 ` Sergei Shtylyov
2012-02-21 19:10 ` [PATCH 0/2] Two trivial omap/serial patches Kevin Hilman
2012-02-21 19:10 ` Kevin Hilman
2012-02-21 19:40 ` NeilBrown
2012-02-21 19:40 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F40FAC0.3010306@ti.com \
--to=shubhrajyoti@ti.com \
--cc=alan@linux.intel.com \
--cc=govindraj.raja@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.