From: Randy Dunlap <rdunlap@xenotime.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] mm: add config NUMA stub to all architectures
Date: Sun, 19 Feb 2012 10:12:29 -0800 [thread overview]
Message-ID: <4F413B8D.5080307@xenotime.net> (raw)
In-Reply-To: <CAMuHMdUYCGoZoUHWMtMCwAJ2ofweaeLF3U89P5EvrNGcn=6apw@mail.gmail.com>
On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote:
> On Fri, Feb 17, 2012 at 21:30, Andrew Morton<akpm@linux-foundation.org> wrote:
>> On Fri, 17 Feb 2012 16:08:15 +0400
>> Konstantin Khlebnikov<khlebnikov@openvz.org> wrote:
>>
>>> Config NUMA must be defined for all architectures,
>>> otherwise IS_ENABLED(CONFIG_NUMA) does not work.
>>> Some arch-specific Kconfig already has this stub.
>>> This patch adds it to all remaining.
>>
>> It would be better to teach IS_ENABLED() to handle this situation. I
>> don't think there's a way of doing this with cpp :(
>>
>> This limitation makes IS_ENABLED pretty dangerous, doesn't it? It
>> makes it very easy to introduce build breakage with unexpected Kconfig
>> combinations.
>
> Indeed. Recently I discovered IS_ENABLED() and started recommending it
> to people for new code. But now I've seen the CONFIG_NUMA breakage,
> I no longer think this is a good recommendation.
adding Michal & linux-kbuild to cc: list.
--
~Randy
next prev parent reply other threads:[~2012-02-19 18:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:20 linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2012-02-17 12:06 ` Konstantin Khlebnikov
2012-02-17 12:08 ` [PATCH] mm: add config NUMA stub to all architectures Konstantin Khlebnikov
2012-02-17 12:45 ` Stephen Rothwell
2012-02-17 13:32 ` Konstantin Khlebnikov
2012-02-17 13:44 ` Sam Ravnborg
2012-02-17 23:39 ` Stephen Rothwell
2012-02-17 20:30 ` Andrew Morton
2012-02-19 17:01 ` Geert Uytterhoeven
2012-02-19 18:12 ` Randy Dunlap [this message]
2012-02-19 23:21 ` Arnaud Lacombe
2012-02-19 23:21 ` Arnaud Lacombe
2012-02-20 14:24 ` Michal Marek
2012-02-19 23:04 ` linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2012-02-19 23:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F413B8D.5080307@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.