From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, linux-mips@linux-mips.org,
linux-wireless@vger.kernel.org, arend@broadcom.com, m@bues.ch
Subject: [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom
Date: Sun, 19 Feb 2012 13:14:04 -0600 [thread overview]
Message-ID: <4F4149FC.50900@lwfinger.net> (raw)
In-Reply-To: <1329676345-15856-3-git-send-email-hauke@hauke-m.de>
On 02/19/2012 12:32 PM, Hauke Mehrtens wrote:
> There is no 2.4 GHz or 5GHz antenna gain stored in sprom. The sprom
> just stores the gain values for antenna 1 and 2 or 1 to 4 for more
> recent sprom versions. On old devices antenna 2 was used for 5 GHz wifi.
>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> ---
> drivers/net/wireless/b43legacy/phy.c | 2 +-
> drivers/ssb/pci.c | 40 ++++++++++++----------------------
> drivers/ssb/pcmcia.c | 12 +++------
> drivers/ssb/sdio.c | 12 +++------
> include/linux/ssb/ssb.h | 7 +-----
> 5 files changed, 24 insertions(+), 49 deletions(-)
After this patch, I get the warning
drivers/ssb/pci.c: In function ?sprom_extract_r123?:
drivers/ssb/pci.c:334:5: warning: unused variable ?gain? [-Wunused-variable]
I am still testing, but all other patches compile OK.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, linux-mips@linux-mips.org,
linux-wireless@vger.kernel.org, arend@broadcom.com, m@bues.ch
Subject: Re: [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom
Date: Sun, 19 Feb 2012 13:14:04 -0600 [thread overview]
Message-ID: <4F4149FC.50900@lwfinger.net> (raw)
In-Reply-To: <1329676345-15856-3-git-send-email-hauke@hauke-m.de>
On 02/19/2012 12:32 PM, Hauke Mehrtens wrote:
> There is no 2.4 GHz or 5GHz antenna gain stored in sprom. The sprom
> just stores the gain values for antenna 1 and 2 or 1 to 4 for more
> recent sprom versions. On old devices antenna 2 was used for 5 GHz wifi.
>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> ---
> drivers/net/wireless/b43legacy/phy.c | 2 +-
> drivers/ssb/pci.c | 40 ++++++++++++----------------------
> drivers/ssb/pcmcia.c | 12 +++------
> drivers/ssb/sdio.c | 12 +++------
> include/linux/ssb/ssb.h | 7 +-----
> 5 files changed, 24 insertions(+), 49 deletions(-)
After this patch, I get the warning
drivers/ssb/pci.c: In function ‘sprom_extract_r123’:
drivers/ssb/pci.c:334:5: warning: unused variable ‘gain’ [-Wunused-variable]
I am still testing, but all other patches compile OK.
Larry
next prev parent reply other threads:[~2012-02-19 19:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 18:32 [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 01/11] ssb: sprom fix some sizes / signedness Hauke Mehrtens
2012-02-23 18:14 ` Rafał Miłecki
2012-02-23 18:14 ` Rafał Miłecki
2012-02-23 21:27 ` Hauke Mehrtens
2012-02-23 21:27 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom Hauke Mehrtens
2012-02-19 19:14 ` Larry Finger [this message]
2012-02-19 19:14 ` Larry Finger
2012-02-19 19:17 ` Hauke Mehrtens
2012-02-19 19:17 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 03/11] ssb: fix per path sprom vars Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 04/11] ssb: add ccode Hauke Mehrtens
2012-02-19 18:49 ` Michael Büsch
2012-02-19 18:49 ` Michael Büsch
2012-02-19 19:28 ` Hauke Mehrtens
2012-02-19 19:28 ` Hauke Mehrtens
2012-02-19 19:50 ` Michael Büsch
2012-02-19 19:50 ` Michael Büsch
2012-02-19 20:01 ` Hauke Mehrtens
2012-02-19 20:01 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 05/11] ssb: add some missing sprom attributes Hauke Mehrtens
2012-02-19 22:16 ` Gábor Stefanik
2012-02-19 22:16 ` Gábor Stefanik
2012-02-19 18:32 ` [PATCH 06/11] bcma: export bcma_find_core Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 07/11] bcma: add support for sprom not found on the device Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 08/11] MIPS: BCM47XX: return number of written bytes in nvram_getenv Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 09/11] MIPS: BCM47XX: fix signature of nvram_parse_macaddr Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 10/11] MIPS: BCM47XX: move and extend sprom parsing Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 11/11] MIPS: BCM47XX: provide sprom to bcma bus Hauke Mehrtens
2012-02-20 11:08 ` Sergei Shtylyov
2012-02-20 11:08 ` Sergei Shtylyov
2012-02-21 19:37 ` [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions John W. Linville
2012-02-21 19:37 ` John W. Linville
2012-02-21 19:52 ` Hauke Mehrtens
2012-02-21 19:52 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4149FC.50900@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.