From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [RFC 00/11]O MAP/ASoC: Move and merge McBSP driver under ASoC
Date: Mon, 20 Feb 2012 10:04:05 +0200 [thread overview]
Message-ID: <4F41FE75.4070003@ti.com> (raw)
In-Reply-To: <CANOLnONVm47DmMv8MdU1Y_Nx-387SZ5MBHwjO4cxkQ_caJ5dWA@mail.gmail.com>
Hi Gražvydas,
On 02/18/2012 11:43 PM, Grazvydas Ignotas wrote:
> On Wed, Feb 15, 2012 at 5:37 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>> Comments, testers are welcome...
>
> Tried these on current mainline and they break sound on pandora:
> # aplay /dev/urandom
> Playing raw data '/dev/urandom' : Unsigned 8 bit, Rate 8000 Hz, Mono
> [ 81.306304] omap-mcbsp: clks: could not clk_set_parent() to pad_fck
> [ 81.313110] ASoC omap3pandora: can't set cpu system clock
> [ 81.319244] asoc: machine hw_params failed
> aplay: set_params:1022: Unable to install hw params:
>
> I've retried without these patches to confirm it works like that, and it did.
Thanks for testing the series.
The issue is that I forgot to remove the pm_runtime_put/get_sync calls
from the moved mcbsp.c file.
Can you manually remove these calls from sound/soc/omap/mcbsp.c ?
It will fix the issue I believe.
I will update the series.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 00/11]O MAP/ASoC: Move and merge McBSP driver under ASoC
Date: Mon, 20 Feb 2012 10:04:05 +0200 [thread overview]
Message-ID: <4F41FE75.4070003@ti.com> (raw)
In-Reply-To: <CANOLnONVm47DmMv8MdU1Y_Nx-387SZ5MBHwjO4cxkQ_caJ5dWA@mail.gmail.com>
Hi Gra?vydas,
On 02/18/2012 11:43 PM, Grazvydas Ignotas wrote:
> On Wed, Feb 15, 2012 at 5:37 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>> Comments, testers are welcome...
>
> Tried these on current mainline and they break sound on pandora:
> # aplay /dev/urandom
> Playing raw data '/dev/urandom' : Unsigned 8 bit, Rate 8000 Hz, Mono
> [ 81.306304] omap-mcbsp: clks: could not clk_set_parent() to pad_fck
> [ 81.313110] ASoC omap3pandora: can't set cpu system clock
> [ 81.319244] asoc: machine hw_params failed
> aplay: set_params:1022: Unable to install hw params:
>
> I've retried without these patches to confirm it works like that, and it did.
Thanks for testing the series.
The issue is that I forgot to remove the pm_runtime_put/get_sync calls
from the moved mcbsp.c file.
Can you manually remove these calls from sound/soc/omap/mcbsp.c ?
It will fix the issue I believe.
I will update the series.
--
P?ter
next prev parent reply other threads:[~2012-02-20 8:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 15:37 [RFC 00/11]O MAP/ASoC: Move and merge McBSP driver under ASoC Peter Ujfalusi
2012-02-15 15:37 ` Peter Ujfalusi
2012-02-18 21:43 ` Grazvydas Ignotas
2012-02-18 21:43 ` Grazvydas Ignotas
2012-02-20 8:04 ` Peter Ujfalusi [this message]
2012-02-20 8:04 ` Peter Ujfalusi
2012-02-20 20:35 ` Grazvydas Ignotas
2012-02-20 20:35 ` Grazvydas Ignotas
-- strict thread matches above, loose matches on Subject: below --
2012-02-15 15:37 Peter Ujfalusi
2012-02-15 15:37 ` Peter Ujfalusi
2012-02-15 15:56 ` Ujfalusi, Peter
2012-02-15 15:56 ` Ujfalusi, Peter
2012-02-15 19:06 ` Jarkko Nikula
2012-02-15 19:06 ` Jarkko Nikula
2012-02-20 10:15 ` Janusz Krzysztofik
2012-02-20 10:15 ` Janusz Krzysztofik
2012-02-15 16:08 ` Mark Brown
2012-02-15 16:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F41FE75.4070003@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.