From: "Arend van Spriel" <arend@broadcom.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
LKML <linux-kernel@vger.kernel.org>,
driverdevel <devel@driverdev.osuosl.org>,
wireless <linux-wireless@vger.kernel.org>,
"linux-hotplug@vger.kernel.org" <linux-hotplug@vger.kernel.org>
Subject: Re: will these methods work with firmware loading?
Date: Mon, 20 Feb 2012 10:32:50 +0000 [thread overview]
Message-ID: <4F422152.3030603@broadcom.com> (raw)
In-Reply-To: <CAPXgP10qa_g6R=pOWd8JuXpw0wPdJ4rP7B_4YHDU91mhC0N6Vg@mail.gmail.com>
On 02/20/2012 11:19 AM, Kay Sievers wrote:
>> For that
>> > problem I would say yes. Also here the problem of handling error flows
>> > exist. If the driver is kicked of during boot with a initramfs missing the
>> > firmware, should we retry until the real root is mounted?
> I don't think so. Drivers are not supposed to know about bootup or
> initramfs issues. If they want, they can disable the timeout, and wait
> for userspace to handle the request any time later, but they should
> not try to be smart here.
>
> Currently, firmware requests are cancelled if the firmware isn't
> found, but that's a userspace issue, and nothing the kernel should try
> to work around.
I can not agree more. I prefer to keep my driver happily unaware. I will
just take the firmware loading away from the module init path and stop
worrying about userspace issues ;-)
Gr. AvS
WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Kay Sievers" <kay.sievers@vrfy.org>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
LKML <linux-kernel@vger.kernel.org>,
driverdevel <devel@driverdev.osuosl.org>,
wireless <linux-wireless@vger.kernel.org>,
"linux-hotplug@vger.kernel.org" <linux-hotplug@vger.kernel.org>
Subject: Re: will these methods work with firmware loading?
Date: Mon, 20 Feb 2012 11:32:50 +0100 [thread overview]
Message-ID: <4F422152.3030603@broadcom.com> (raw)
In-Reply-To: <CAPXgP10qa_g6R=pOWd8JuXpw0wPdJ4rP7B_4YHDU91mhC0N6Vg@mail.gmail.com>
On 02/20/2012 11:19 AM, Kay Sievers wrote:
>> For that
>> > problem I would say yes. Also here the problem of handling error flows
>> > exist. If the driver is kicked of during boot with a initramfs missing the
>> > firmware, should we retry until the real root is mounted?
> I don't think so. Drivers are not supposed to know about bootup or
> initramfs issues. If they want, they can disable the timeout, and wait
> for userspace to handle the request any time later, but they should
> not try to be smart here.
>
> Currently, firmware requests are cancelled if the firmware isn't
> found, but that's a userspace issue, and nothing the kernel should try
> to work around.
I can not agree more. I prefer to keep my driver happily unaware. I will
just take the firmware loading away from the module init path and stop
worrying about userspace issues ;-)
Gr. AvS
next prev parent reply other threads:[~2012-02-20 10:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 18:40 will these methods work with firmware loading? Larry Finger
2012-02-19 18:40 ` Larry Finger
2012-02-20 9:46 ` Johannes Berg
2012-02-20 9:46 ` Johannes Berg
2012-02-20 10:01 ` Arend van Spriel
2012-02-20 10:01 ` Arend van Spriel
2012-02-20 10:19 ` Kay Sievers
2012-02-20 10:19 ` Kay Sievers
2012-02-20 10:32 ` Arend van Spriel [this message]
2012-02-20 10:32 ` Arend van Spriel
2012-02-20 20:12 ` Larry Finger
2012-02-20 20:12 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F422152.3030603@broadcom.com \
--to=arend@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.