From: Daniel J Blueman <daniel@numascale-asia.com>
To: Borislav Petkov <bp@amd64.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Steffen Persvold <sp@numascale.com>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH] x86: Remove wrong error message in x86_default_fixup_cpu_id
Date: Tue, 21 Feb 2012 12:56:45 +0000 [thread overview]
Message-ID: <4F43948D.8070709@numascale-asia.com> (raw)
In-Reply-To: <20120221112042.GE14274@aftab>
On 21/02/2012 11:20, Borislav Petkov wrote:
> On Tue, Feb 21, 2012 at 11:05:21AM +0000, Daniel J Blueman wrote:
>> The check and fixup wasn't needed in the Intel path thus far, so
>> wasn't added.
>>
>> We could specialise the 'if (c->phys_proc_id != node)' test to check
>> for x86_cpuinit.fixup_cpu_id being NULL and drop the default
>> override, if that is preferred?
> Before that, why do you need that check in the AMD path at all? Please
> give a more detailed explanation as to why is it needed on the AMD path
> at all.
Since Numascale's NumaConnect bridges multiple separate HyperTransport
fabrics across multiple servers together, the HT IDs written in the
hardware thus don't match the information in the SRAT table constructed
in the bootloader, thus we need to set this to the logical value [1,
'fixup_cpu_id'].
[1] https://lkml.org/lkml/2011/12/5/292
--
Daniel J Blueman
Principal Software Engineer, Numascale Asia
next prev parent reply other threads:[~2012-02-21 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 17:17 [PATCH] x86: Remove wrong error message in x86_default_fixup_cpu_id Andreas Herrmann
2012-02-21 10:27 ` Borislav Petkov
2012-02-21 11:05 ` Daniel J Blueman
2012-02-21 11:20 ` Borislav Petkov
2012-02-21 12:56 ` Daniel J Blueman [this message]
2012-02-22 13:47 ` Andreas Herrmann
2012-02-23 10:23 ` Daniel J Blueman
2012-02-24 15:31 ` [PATCH resend] " Andreas Herrmann
2012-02-27 12:07 ` [tip:x86/platform] x86/platform: Remove incorrect error message in x86_default_fixup_cpu_id() tip-bot for Andreas Herrmann
2012-02-28 15:27 ` Borislav Petkov
2012-02-28 16:42 ` [tip:x86/urgent] " tip-bot for Andreas Herrmann
2012-03-02 11:04 ` Ingo Molnar
2012-03-02 11:51 ` Andreas Herrmann
2012-04-02 16:06 ` [PATCH resend] " Andreas Herrmann
2012-04-04 12:38 ` Borislav Petkov
2012-04-16 17:31 ` Borislav Petkov
2012-04-16 18:53 ` [tip:x86/urgent] " tip-bot for Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F43948D.8070709@numascale-asia.com \
--to=daniel@numascale-asia.com \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sp@numascale.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.