From: michael.thalmeier@hale.at (Michael Thalmeier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX31: mxc-rnga: implement waiting for data in driver
Date: Tue, 21 Feb 2012 15:39:09 +0100 [thread overview]
Message-ID: <4F43AC8D.5090508@hale.at> (raw)
In-Reply-To: <CAOMZO5BGVa0HRKqv9nKQUy9iGnQ3FV_6OnguMyk3rAinaJkb6w@mail.gmail.com>
On 2012-02-21 14:29, Fabio Estevam wrote:
> On Tue, Feb 21, 2012 at 10:13 AM, Michael Thalmeier
> <michael.thalmeier@hale.at> wrote:
>
>> -static int mxc_rnga_data_present(struct hwrng *rng)
>> +static int mxc_rnga_data_present(struct hwrng *rng, int wait)
>
> This looks good, but ...
>
>> {
>> - int level;
>> + int level, i;
>> void __iomem *rng_base = (void __iomem *)rng->priv;
>>
>> - /* how many random numbers is in FIFO? [0-16] */
>> - level = ((__raw_readl(rng_base + RNGA_STATUS) &
>> - RNGA_STATUS_LEVEL_MASK) >> 8);
>> + for (i = 0; i < 20; i++) {
>
> Why the magic "20" here?
>
> It would be better to add a proper timeout mechanism instead, such as
> time_after(jiffies, timeout)
>
I am absolutely with you.
The point is only that this is the behaviour of nearly all hw_random
drivers, and I basically just copied it over into this driver.
--
Scanned by MailScanner.
WARNING: multiple messages have this Message-ID (diff)
From: Michael Thalmeier <michael.thalmeier@hale.at>
To: Fabio Estevam <festevam@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, michael@thalmeier.at,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i.MX31: mxc-rnga: implement waiting for data in driver
Date: Tue, 21 Feb 2012 15:39:09 +0100 [thread overview]
Message-ID: <4F43AC8D.5090508@hale.at> (raw)
In-Reply-To: <CAOMZO5BGVa0HRKqv9nKQUy9iGnQ3FV_6OnguMyk3rAinaJkb6w@mail.gmail.com>
On 2012-02-21 14:29, Fabio Estevam wrote:
> On Tue, Feb 21, 2012 at 10:13 AM, Michael Thalmeier
> <michael.thalmeier@hale.at> wrote:
>
>> -static int mxc_rnga_data_present(struct hwrng *rng)
>> +static int mxc_rnga_data_present(struct hwrng *rng, int wait)
>
> This looks good, but ...
>
>> {
>> - int level;
>> + int level, i;
>> void __iomem *rng_base = (void __iomem *)rng->priv;
>>
>> - /* how many random numbers is in FIFO? [0-16] */
>> - level = ((__raw_readl(rng_base + RNGA_STATUS) &
>> - RNGA_STATUS_LEVEL_MASK) >> 8);
>> + for (i = 0; i < 20; i++) {
>
> Why the magic "20" here?
>
> It would be better to add a proper timeout mechanism instead, such as
> time_after(jiffies, timeout)
>
I am absolutely with you.
The point is only that this is the behaviour of nearly all hw_random
drivers, and I basically just copied it over into this driver.
--
Scanned by MailScanner.
next prev parent reply other threads:[~2012-02-21 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 12:13 [PATCH] i.MX31: mxc-rnga: implement waiting for data in driver Michael Thalmeier
2012-02-21 12:13 ` Michael Thalmeier
2012-02-21 13:29 ` Fabio Estevam
2012-02-21 13:29 ` Fabio Estevam
2012-02-21 14:39 ` Michael Thalmeier [this message]
2012-02-21 14:39 ` Michael Thalmeier
2012-02-23 13:37 ` Arnd Bergmann
2012-02-23 13:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F43AC8D.5090508@hale.at \
--to=michael.thalmeier@hale.at \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.