From: Hauke Mehrtens <hauke@hauke-m.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org, m@bues.ch
Subject: [RFC] b43: fix memory leak on bcm5354
Date: Tue, 21 Feb 2012 20:11:51 +0100 [thread overview]
Message-ID: <4F43EC77.6030409@hauke-m.de> (raw)
In-Reply-To: <4F42EBFC.4060307@lwfinger.net>
On 02/21/2012 01:57 AM, Larry Finger wrote:
> On 02/20/2012 05:38 PM, Hauke Mehrtens wrote:
>> When using the bcm5354 with a recent firmware>= 478.104 it runs into a
>> memory very shortly after doing an active scan or any thing else where
>
> You are missing a word after memory.
It leaked to somewhere else. ;-)
>> packages are send. This was cased by a gpio misconfiguration, the
>> firmware triggered the GPIO pins used for buttons on some devices and
>> that caused an other driver (OpenWrt diag) listening for these buttons
>> to send many user space messages.
>> This patch fixes the bug for my devices (Asus WL-520GU) and makes it
>> work with firmware 666.2, but I do not know if this patch is correct.
>> The spec for this part is out of date:
>> http://bcm-specs.sipsolutions.net/GPIO
>
> I just updated the specs based on additional info I found. Everything I
> see say that there are 4 bits for the LEDs. Do you have a source for
> what you posted below?
Thanks for updating the spec, but this is nothing special for the
bcm5354. My device just has one WLAN LED, like many SoCs.
>> GPIO pin layout:
>> pin# name type
>> 0 power led
>> 1 wlan led
>> 2 reset button
>> 3 ses buttom
This is from the Asus WL-520GU section of the the OpenWrt diag driver
[0] and I verified it myself on this device.
>> related nvram configuration:
>> wl0gpio2=11
>> wl0gpio3=11
>> wl0gpio0=11
>> wl0gpio1=0x02
>> reset_gpio=2
This was extracted from the nvram of the Asus W-520GU with "nvram show
|grep gpio". This was a used device, so I do not know if someone else
already did some modifications to the nvram.
Hauke
[0]: https://dev.openwrt.org/browser/trunk/package/broadcom-diag/src/diag.c
WARNING: multiple messages have this Message-ID (diff)
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org, m@bues.ch
Subject: Re: [RFC] b43: fix memory leak on bcm5354
Date: Tue, 21 Feb 2012 20:11:51 +0100 [thread overview]
Message-ID: <4F43EC77.6030409@hauke-m.de> (raw)
In-Reply-To: <4F42EBFC.4060307@lwfinger.net>
On 02/21/2012 01:57 AM, Larry Finger wrote:
> On 02/20/2012 05:38 PM, Hauke Mehrtens wrote:
>> When using the bcm5354 with a recent firmware>= 478.104 it runs into a
>> memory very shortly after doing an active scan or any thing else where
>
> You are missing a word after memory.
It leaked to somewhere else. ;-)
>> packages are send. This was cased by a gpio misconfiguration, the
>> firmware triggered the GPIO pins used for buttons on some devices and
>> that caused an other driver (OpenWrt diag) listening for these buttons
>> to send many user space messages.
>> This patch fixes the bug for my devices (Asus WL-520GU) and makes it
>> work with firmware 666.2, but I do not know if this patch is correct.
>> The spec for this part is out of date:
>> http://bcm-specs.sipsolutions.net/GPIO
>
> I just updated the specs based on additional info I found. Everything I
> see say that there are 4 bits for the LEDs. Do you have a source for
> what you posted below?
Thanks for updating the spec, but this is nothing special for the
bcm5354. My device just has one WLAN LED, like many SoCs.
>> GPIO pin layout:
>> pin# name type
>> 0 power led
>> 1 wlan led
>> 2 reset button
>> 3 ses buttom
This is from the Asus WL-520GU section of the the OpenWrt diag driver
[0] and I verified it myself on this device.
>> related nvram configuration:
>> wl0gpio2=11
>> wl0gpio3=11
>> wl0gpio0=11
>> wl0gpio1=0x02
>> reset_gpio=2
This was extracted from the nvram of the Asus W-520GU with "nvram show
|grep gpio". This was a used device, so I do not know if someone else
already did some modifications to the nvram.
Hauke
[0]: https://dev.openwrt.org/browser/trunk/package/broadcom-diag/src/diag.c
next prev parent reply other threads:[~2012-02-21 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 23:38 [RFC] b43: fix memory leak on bcm5354 Hauke Mehrtens
2012-02-21 0:57 ` Larry Finger
2012-02-21 0:57 ` Larry Finger
2012-02-21 19:11 ` Hauke Mehrtens [this message]
2012-02-21 19:11 ` Hauke Mehrtens
2012-02-21 9:48 ` Florian Fainelli
2012-02-21 9:48 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F43EC77.6030409@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.